Update EIP-7708: Provide more details and add fee payments #9003
+25
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add details about log `address` and suggest concrete `topics[0]` values. Further propose a fee payment log for completeness. Withdrawals and priority fees could be covered with block level system logs, as proposed here: - https://github.com/ethereum/EIPs/pull/9002/files Early prototype is getting implemented at https://fusaka-light.box
github-actions
bot
added
c-update
File
|
etan-status
commented
Oct 29, 2024
|
|
||
| ### Functionality | ||
| - Any transaction (including zero-value-transferring), before any other logs created by EVM execution |
There was a problem hiding this comment.
Rationale being that something still happened on the wallet that may be of interest to the user. This is only on the outermost call.
xoxoabbyjean95
approved these changes
Oct 31, 2024
xoxoabbyjean95
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add details about log
addressand suggest concretetopics[0]values. Further propose a fee payment log for completeness.Withdrawals and priority fees could be covered with block level system logs, as proposed here:
Early prototype is getting implemented at https://fusaka-light.box