core/state: tests on the binary iterator #30754
Merged
+172
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
force-pushed
the
iterator_fixes-2
branch
from
3318909
to
e9fc202
Compare
|
This PR now contains additional test coverage, and fails as expected two tests concerning deletes. @rjl493456442 want to push your fixes on top here? |
|
@rjl493456442 I pushed a different fix now. Sorry for the noise :) |
| if !it.next() { | ||
| return false | ||
| } | ||
| if len(it.Account()) == 0 && len(it.Slot()) == 0 { |
There was a problem hiding this comment.
We should also check the it.Fail.
it.Fail might be set if any error occurs by calling it.Account() or it.Slot(). If so, we should return false and stop iteration.
We can go with this pull request and I will rebase my stuff on top |
rjl493456442
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress
cc @rjl493456442