-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add carrier orders list #1218
base: develop
Are you sure you want to change the base?
Conversation
<ion-label> | ||
<p>name: {{ order.warehouse.name }}</p> | ||
<p>Phone: {{ order.warehouse.contactPhone }}</p> | ||
<p>Email: {{ order.warehouse.cantactEmail }}</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@valiopld did you tested this? Is it not a typo .cantactEmail
???
<img [src]="order.warehouse.logo" /> | ||
</ion-avatar> | ||
<ion-label> | ||
<p>name: {{ order.warehouse.name }}</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@valiopld why "name", but "Phone", where is consistency (even if it's ugly, things should be consistently ugly)
@valiopld what is status of this? Can you attach video? |
https://www.loom.com/share/7fc156642ed24124bff849a7e1e6074a **The text, for now, is hardcoded later I will add translates |
@AlishMekliov931 at some point, we will need to review this and merge it too. |
|
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.