Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add carrier orders list #1218

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Conversation

evereq
Copy link
Member

@evereq evereq commented Jul 12, 2020

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.


<ion-label>
<p>name: {{ order.warehouse.name }}</p>
<p>Phone: {{ order.warehouse.contactPhone }}</p>
<p>Email: {{ order.warehouse.cantactEmail }}</p>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@valiopld did you tested this? Is it not a typo .cantactEmail???

<img [src]="order.warehouse.logo" />
</ion-avatar>
<ion-label>
<p>name: {{ order.warehouse.name }}</p>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@valiopld why "name", but "Phone", where is consistency (even if it's ugly, things should be consistently ugly)

@evereq
Copy link
Member Author

evereq commented Jul 18, 2020

@valiopld what is status of this? Can you attach video?

@valiopld
Copy link
Contributor

https://www.loom.com/share/7fc156642ed24124bff849a7e1e6074a
@evereq
I need advice on how the card should look like

**The text, for now, is hardcoded later I will add translates
** the alert will be replaced will ion-alert
** the error in the console is because too many requests with on google map API (not sure)

@valiopld valiopld marked this pull request as ready for review July 28, 2020 12:00
@evereq
Copy link
Member Author

evereq commented Oct 27, 2020

@AlishMekliov931 at some point, we will need to review this and merge it too.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants