Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add removal of gas-limited constraints to gas-savings proposal #1098

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Jan 7, 2025

@rvagg
Copy link
Member Author

rvagg commented Jan 7, 2025

Since this is a PR to a PR it doesn't need full approval and review by editors, but it does need approval from @irenegia, @AxCortesCubero & @zixuanzh to mess with their FIP doc.

But of course if anyone else wants to suggest edits, raise objections or suggest that this will decrease the likelihood of the original FIP being accepted, please speak up!

Copy link
Member

@jsoares jsoares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor editorial comments. I don't otherwise see anything that warrants comments at this intermediate stage; the changes don't strike me as negatively impacting potential acceptance.

FIPS/fip-lowerbatchBal.md Show resolved Hide resolved
FIPS/fip-lowerbatchBal.md Show resolved Hide resolved
@anorth
Copy link
Member

anorth commented Jan 13, 2025

Happy to merge when @irenegia approves

@irenegia irenegia merged commit f2e3e3c into irenegia-patch-3 Jan 15, 2025
@irenegia irenegia deleted the rvagg/remove-gas-limited branch January 15, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🎉 Done
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants