[WIP] Remove unused and deprecated code

actors/account/src/lib.rs

@@ -32,8 +32,6 @@ fil_actors_runtime::wasm_trampoline!(Actor);
 pub enum Method {
     Constructor = METHOD_CONSTRUCTOR,
     PubkeyAddress = 2,
-    // Deprecated in v10
-    // AuthenticateMessage = 3,
     AuthenticateMessageExported = frc42_dispatch::method_hash!("AuthenticateMessage"),
 }
 

actors/datacap/src/lib.rs

@@ -51,21 +51,6 @@ lazy_static! {
 #[repr(u64)]
 pub enum Method {
     Constructor = METHOD_CONSTRUCTOR,
-    // Deprecated in v10
-    // Mint = 2,
-    // Destroy = 3,
-    // Name = 10,
-    // Symbol = 11,
-    // TotalSupply = 12,
-    // BalanceOf = 13,
-    // Transfer = 14,
-    // TransferFrom = 15,
-    // IncreaseAllowance = 16,
-    // DecreaseAllowance = 17,
-    // RevokeAllowance = 18,
-    // Burn = 19,
-    // BurnFrom = 20,
-    // Allowance = 21,
     // Method numbers derived from FRC-0042 standards
     MintExported = frc42_dispatch::method_hash!("Mint"),
     DestroyExported = frc42_dispatch::method_hash!("Destroy"),

actors/market/src/lib.rs

@@ -76,8 +76,7 @@ pub enum Method {
     VerifyDealsForActivation = 5,
     BatchActivateDeals = 6,
     OnMinerSectorsTerminate = 7,
-    // ComputeDataCommitment = 8, // Deprecated
-    CronTick = 9,
+    CronTick = 8,
     // Method numbers derived from FRC-0042 standards
     AddBalanceExported = frc42_dispatch::method_hash!("AddBalance"),
     WithdrawBalanceExported = frc42_dispatch::method_hash!("WithdrawBalance"),

actors/miner/src/lib.rs

@@ -1423,26 +1423,19 @@ impl Actor {
             .sectors
             .into_iter()
             .map(|spci| {
-                if spci.replace_capacity {
-                    Err(actor_error!(
-                        forbidden,
-                        "cc upgrade through precommit discontinued, use ProveReplicaUpdate"
-                    ))
-                } else {
-                    Ok(SectorPreCommitInfoInner {
-                        seal_proof: spci.seal_proof,
-                        sector_number: spci.sector_number,
-                        sealed_cid: spci.sealed_cid,
-                        seal_rand_epoch: spci.seal_rand_epoch,
-                        deal_ids: spci.deal_ids,
-                        expiration: spci.expiration,
-                        // This entry point computes the unsealed CID from deals via the market.
-                        // A future one will accept it directly as a parameter.
-                        unsealed_cid: None,
-                    })
+                SectorPreCommitInfoInner {
+                    seal_proof: spci.seal_proof,
+                    sector_number: spci.sector_number,
+                    sealed_cid: spci.sealed_cid,
+                    seal_rand_epoch: spci.seal_rand_epoch,
+                    deal_ids: spci.deal_ids,
+                    expiration: spci.expiration,
+                    // This entry point computes the unsealed CID from deals via the market.
+                    // A future one will accept it directly as a parameter.
+                    unsealed_cid: None,
                 }
             })
-            .collect::<Result<_, _>>()?;
+            .collect::<Vec<SectorPreCommitInfoInner>>();
         Self::pre_commit_sector_batch_inner(rt, sectors)
     }
 

actors/miner/src/testing.rs

@@ -599,12 +599,6 @@ impl PartitionStateSummary {
 struct ExpirationQueueStateSummary {
     pub on_time_sectors: BitField,
     pub early_sectors: BitField,
-    #[allow(dead_code)]
-    pub active_power: PowerPair,
-    #[allow(dead_code)]
-    pub faulty_power: PowerPair,
-    #[allow(dead_code)]
-    pub on_time_pledge: TokenAmount,
     pub expiration_epochs: Vec<ChainEpoch>,
 }
 
@@ -697,14 +691,7 @@ impl ExpirationQueueStateSummary {
         let union_on_time = BitField::union(&all_on_time);
         let union_early = BitField::union(&all_early);
 
-        Self {
-            on_time_sectors: union_on_time,
-            early_sectors: union_early,
-            active_power: all_active_power,
-            faulty_power: all_faulty_power,
-            on_time_pledge: all_on_time_pledge,
-            expiration_epochs,
-        }
+        Self { on_time_sectors: union_on_time, early_sectors: union_early, expiration_epochs }
     }
 }
 

actors/miner/src/types.rs

@@ -293,12 +293,6 @@ pub struct PreCommitSectorParams {
     pub seal_rand_epoch: ChainEpoch,
     pub deal_ids: Vec<DealID>,
     pub expiration: ChainEpoch,
-    /// Deprecated:
-    /// Whether to replace a "committed capacity" no-deal sector (requires non-empty DealIDs)
-    pub replace_capacity: bool,
-    /// Deprecated:
-    /// The committed capacity sector to replace, and its deadline/partition location
-    pub replace_sector_deadline: u64,
     pub replace_sector_partition: u64,
     pub replace_sector_number: SectorNumber,
 }

actors/miner/tests/util.rs

@@ -517,9 +517,6 @@ impl ActorHarness {
             seal_rand_epoch: challenge,
             deal_ids: sector_deal_ids,
             expiration,
-            // unused
-            replace_capacity: false,
-            replace_sector_deadline: 0,
             replace_sector_partition: 0,
             replace_sector_number: 0,
         }
@@ -578,9 +575,6 @@ impl ActorHarness {
                         seal_rand_epoch: s.seal_rand_epoch,
                         deal_ids: s.deal_ids.clone(),
                         expiration: s.expiration,
-                        // unused
-                        replace_capacity: false,
-                        replace_sector_deadline: 0,
                         replace_sector_partition: 0,
                         replace_sector_number: 0,
                     }

actors/power/src/lib.rs

@@ -59,10 +59,8 @@ pub enum Method {
     EnrollCronEvent = 4,
     OnEpochTickEnd = 5,
     UpdatePledgeTotal = 6,
-    // * Deprecated in v2
-    // OnConsensusFault = 7,
-    SubmitPoRepForBulkVerify = 8,
-    CurrentTotalPower = 9,
+    SubmitPoRepForBulkVerify = 7,
+    CurrentTotalPower = 8,
     // Method numbers derived from FRC-0042 standards
     CreateMinerExported = frc42_dispatch::method_hash!("CreateMiner"),
     NetworkRawPowerExported = frc42_dispatch::method_hash!("NetworkRawPower"),

actors/verifreg/src/lib.rs

@@ -56,14 +56,12 @@ pub enum Method {
     AddVerifier = 2,
     RemoveVerifier = 3,
     AddVerifiedClient = 4,
-    // UseBytes = 5,     // Deprecated
-    // RestoreBytes = 6, // Deprecated
-    RemoveVerifiedClientDataCap = 7,
-    RemoveExpiredAllocations = 8,
-    ClaimAllocations = 9,
-    GetClaims = 10,
-    ExtendClaimTerms = 11,
-    RemoveExpiredClaims = 12,
+    RemoveVerifiedClientDataCap = 5,
+    RemoveExpiredAllocations = 6,
+    ClaimAllocations = 7,
+    GetClaims = 8,
+    ExtendClaimTerms = 9,
+    RemoveExpiredClaims = 10,
     // Method numbers derived from FRC-0042 standards
     AddVerifiedClientExported = frc42_dispatch::method_hash!("AddVerifiedClient"),
     RemoveExpiredAllocationsExported = frc42_dispatch::method_hash!("RemoveExpiredAllocations"),

integration_tests/src/util/workflows.rs

@@ -148,8 +148,6 @@ pub fn miner_precommit_sector(
         seal_rand_epoch: v.epoch() - 1,
         deal_ids,
         expiration,
-        replace_capacity: false,
-        replace_sector_deadline: 0,
         replace_sector_partition: 0,
         replace_sector_number: 0,
     };

runtime/src/runtime/fvm.rs

@@ -76,11 +76,6 @@ impl<B> FvmRuntime<B> {
         }
         Ok(())
     }
-
-    #[allow(dead_code)]
-    fn policy_mut(&mut self) -> &mut Policy {
-        &mut self.policy
-    }
 }
 
 /// A stub MessageInfo implementation performing FVM syscalls to obtain its fields.

src/lib.rs

@@ -1,3 +1,4 @@
+#![warn(dead_code)]
 /// The bundled CAR embedded as a byte slice for easy consumption by Rust programs.
 ///
 /// The root CID of the CAR points to an actor index data structure. It is a

src/main.rs

@@ -1,3 +1,5 @@
+#![warn(dead_code)]
+
 use clap::Parser;
 use std::io::Write;