Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/remove pending allocation #110

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

gstraczek
Copy link
Contributor

@gstraczek gstraczek commented Jun 26, 2024

Pull Request Template

Description

Added button 'Remove pending allocation' to unblock allocation request.

Fixes # (issue reference)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Application must be in state: 'ReadyToSign'

Checklist:

Before submitting your pull request, please review the following checklist:

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Additional Information

Any additional information, configuration, or data that might be necessary to reproduce the issue or test the feature.

Screenshots (if appropriate)

image

@gstraczek gstraczek requested a review from kacperzuk-neti June 26, 2024 14:40
@gstraczek gstraczek force-pushed the feature/remove-pending-allocation branch from 342de6f to 4474307 Compare June 26, 2024 14:55
Copy link
Collaborator

@kacperzuk-neti kacperzuk-neti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will approve & merge after it's successfully tested on staging (which is blocked by unrelated issues)

@kacperzuk-neti kacperzuk-neti merged commit 07c21a8 into main Jul 1, 2024
2 checks passed
@kacperzuk-neti kacperzuk-neti deleted the feature/remove-pending-allocation branch July 1, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants