Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gamescope #51

Merged
merged 6 commits into from
Apr 2, 2023
Merged

Gamescope #51

merged 6 commits into from
Apr 2, 2023

Conversation

Lonsfor
Copy link
Contributor

@Lonsfor Lonsfor commented Mar 12, 2023

add ability to use the com.valvesoftware.Steam.Utility.gamescope extension and bump the runtime to 22.08
#50

@flathubbot
Copy link
Contributor

Started test build 28091

@Lonsfor
Copy link
Contributor Author

Lonsfor commented Mar 12, 2023

i runned into a rabbit hole but here it is.

@Eoin-ONeill-Yokai you are going to have to be the one to test it because i dont have wayland and the game comes out messed up.
Screenshot_2023-03-12_18-37-15

use the env variables GAMESCOPE_ENABLE and GAMESCOPE_ARGS. so GAMESCOPE_ENABLE=1 flatpak run org.srb2kart also test srb2kart with -opengl and -software

@flathubbot
Copy link
Contributor

Build 28091 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/10759/org.srb2.SRB2Kart.flatpakref

@Eoin-ONeill-Yokai
Copy link

Eoin-ONeill-Yokai commented Mar 13, 2023

I'll go ahead and test it out tonight.

@Eoin-ONeill-Yokai
Copy link

Eoin-ONeill-Yokai commented Mar 14, 2023

That works flawlessly.

image

Might be worth adding some default arguments to gamescope in the case that the user doesn't supply, specifically something like

-h 1080 -C 1000 -i

Which simply sets internal resolution to 1080p (the game is picky about resolutions it can run in, so best to force a known good one. You can see in the screenshot above that the top part of the screen is "stretching" and this can be solved by setting the internal renderer to 1080) hides the cursor after 1 second (just to keep the mouse cursor out of the way) and also applies a integer upscale when scaling (since it's the best upscale method for this type of game IMO). Otherwise it works great!

@Lonsfor
Copy link
Contributor Author

Lonsfor commented Mar 14, 2023

what difference is there with setting -h 1080 and just changing the resolution withing the game?

@Eoin-ONeill-Yokai
Copy link

what difference is there with setting -h 1080 and just changing the resolution withing the game?

Well, the default launch options of SRB2Kart (on my system at least, I'm sure this will change from system to system) starts at 1280x800 which creates the following artifact at the top of the screen:

image

This can be solved by either changing resolution to 1280x720 for me.

Setting the internal resolution would mean that all users would be treated as having the same "monitor" and the results would then be scaled.

Regardless, this doesn't need to be fixed here necessarily -- it could be an upstream issue.

@flathubbot
Copy link
Contributor

Started test build 29032

@Lonsfor
Copy link
Contributor Author

Lonsfor commented Mar 17, 2023

i am having trouble visualizing what you said so i am just going to use your original suggestion and if someone else is having problems they can make an issue.

@Lonsfor Lonsfor changed the title draft: Gamescope Gamescope Mar 17, 2023
@flathubbot
Copy link
Contributor

Build 29032 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/11696/org.srb2.SRB2Kart.flatpakref

@Lonsfor
Copy link
Contributor Author

Lonsfor commented Mar 29, 2023

@ghisvail you still there?

@flathubbot
Copy link
Contributor

Started test build 31529

@flathubbot
Copy link
Contributor

Build 31529 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/14182/org.srb2.SRB2Kart.flatpakref

org.srb2.SRB2Kart.yaml Show resolved Hide resolved
@ghisvail ghisvail merged commit 98f102c into flathub:master Apr 2, 2023
@ghisvail ghisvail mentioned this pull request Apr 2, 2023
@Eoin-ONeill-Yokai
Copy link

Awesome, thanks again @Lonsfor and @ghisvail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants