Support windows #27
Merged
Support windows #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ksew1
force-pushed
the
support-windows
branch
7 times, most recently
from
b60fb34 to
b7be629
Compare
ksew1
force-pushed
the
support-windows
branch
from
b7be629 to
6f94dd8
Compare
THenry14
reviewed
Feb 3, 2025
| using: "composite" | ||
| steps: | ||
| - name: Set up Universal Sierra Compiler | ||
| uses: software-mansion/setup-universal-sierra-compiler@v1 |
There was a problem hiding this comment.
this means usc is implicitly included each time someone uses snfoundry action? if so - neat.
how did you test this?
There was a problem hiding this comment.
this means usc is implicitly included each time someone uses snfoundry action? if so - neat.
Yepsetup-snfoundryaction automatically installsusc
how did you test this?
This part of ci is testing it:
https://github.com/foundry-rs/setup-snfoundry/blob/106e83ff8dca36e29fd972d68127540fe7355e71/.github/workflows/checks.yml#L45C1-L51C49
THenry14
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25
Related: software-mansion/cairo-coverage#103
This probably should be closed: software-mansion/universal-sierra-compiler#60