Support for prebuilt plugin #2864
Open
+178
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cb8a3d5.
kkawula
changed the title
kkawula
requested review from
cptartur,
ddoktorski and
franciszekjob
as code owners
ddoktorski
reviewed
Jan 24, 2025
Co-authored-by: ddoktorski <[email protected]>
cptartur
reviewed
Jan 28, 2025
CHANGELOG.md
Outdated
Comment on lines
12
to
20
| #### Added | ||
|
|
||
| - Newly created projects won't require Rust to be installed by default | ||
|
|
||
| ### `snforge_scarb_plugin` | ||
|
|
||
| #### Changed | ||
|
|
||
| - Precompiled plugin binaries are now published to the registry for new versions |
There was a problem hiding this comment.
Maybe let's just combine these into single Forge #### Changed entry?
| @@ -96,6 +96,7 @@ fn update_config(config_path: &Path, scarb: &Version) -> Result<()> { | |||
| set_cairo_edition(&mut document, CAIRO_EDITION); | |||
| add_test_script(&mut document); | |||
| add_assert_macros(&mut document, scarb)?; | |||
| add_allow_prebuilt_macros(&mut document)?; | |||
There was a problem hiding this comment.
I don't think this should always be added. What about older scarb versions that do not support prebuilt macros?
Co-authored-by: Artur Michałek <[email protected]>
THenry14
reviewed
Jan 29, 2025
| @@ -5,33 +5,146 @@ on: | |||
| workflow_dispatch: | |||
|
|
|||
| jobs: | |||
| upload-to-registry: | |||
| name: Upload plugin to the registry | |||
| check-version: | |||
There was a problem hiding this comment.
nitpick: technically it's true, but actually you're checking is_version_uploaded or version_exists or just plain upload_requirements. maybe this could be improved?
There was a problem hiding this comment.
For me, it looks well in the context I use it. Just referencing to outputs
needs: check-version
if: needs.check-version.outputs.plugin_uploaded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2827
Introduced changes
publish_pluginworkflow to compile plugin for different platforms.Checklist
CHANGELOG.md