Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for prebuilt plugin #2864

Merged
merged 33 commits into from
Feb 3, 2025

Conversation

kkawula
Copy link
Member

@kkawula kkawula commented Jan 21, 2025

Closes #2827

Introduced changes

  • Updated publish_plugin workflow to compile plugin for different platforms.

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@kkawula kkawula changed the title Kkawula/2827 support for prebuilt packages in scarb Support for prebuilt plugin Jan 23, 2025
@kkawula kkawula marked this pull request as ready for review January 23, 2025 09:43
Copy link
Collaborator

@franciszekjob franciszekjob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the description of PR.

.github/workflows/publish_plugin.yml Show resolved Hide resolved
crates/forge/tests/e2e/running.rs Outdated Show resolved Hide resolved
crates/forge/src/new.rs Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@cptartur cptartur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@THenry14 can you review the scripts (gh action) part of this?

.github/workflows/publish_plugin.yml Outdated Show resolved Hide resolved
.github/workflows/publish_plugin.yml Show resolved Hide resolved
.github/workflows/publish_plugin.yml Outdated Show resolved Hide resolved
.github/workflows/publish_plugin.yml Outdated Show resolved Hide resolved
.github/workflows/publish_plugin.yml Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
crates/forge/src/new.rs Show resolved Hide resolved
crates/forge/tests/e2e/running.rs Outdated Show resolved Hide resolved
docs/src/appendix/scarb-toml.md Outdated Show resolved Hide resolved
docs/src/getting-started/first-steps.md Show resolved Hide resolved
@cptartur cptartur requested a review from THenry14 January 28, 2025 13:30
.github/workflows/publish_plugin.yml Show resolved Hide resolved
.github/workflows/publish_plugin.yml Outdated Show resolved Hide resolved
.github/workflows/publish_plugin.yml Outdated Show resolved Hide resolved
docs/src/appendix/scarb-toml.md Outdated Show resolved Hide resolved
docs/src/appendix/scarb-toml.md Outdated Show resolved Hide resolved
@kkawula kkawula requested a review from cptartur January 31, 2025 08:22
CHANGELOG.md Outdated Show resolved Hide resolved
docs/src/appendix/scarb-toml.md Show resolved Hide resolved
Co-authored-by: Artur Michałek <[email protected]>
.github/workflows/publish_plugin.yml Outdated Show resolved Hide resolved
.github/workflows/publish_plugin.yml Show resolved Hide resolved
@kkawula kkawula requested a review from cptartur January 31, 2025 15:49
@cptartur cptartur enabled auto-merge February 3, 2025 13:11
@cptartur cptartur added this pull request to the merge queue Feb 3, 2025
Merged via the queue into master with commit 5f11473 Feb 3, 2025
38 checks passed
@cptartur cptartur deleted the kkawula/2827-support-for-prebuilt-packages-in-scarb branch February 3, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for prebuilt packages in scarb
5 participants