Clean implementation #2882
Merged
Clean implementation #2882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksew1
reviewed
Jan 28, 2025
Nemezjusz
requested review from
cptartur,
ddoktorski,
kkawula and
franciszekjob
as code owners
ksew1
reviewed
Jan 30, 2025
<!-- Reference any GitHub issues resolved by this PR --> ## Introduced changes There was an issue where, when validating `Scarb.toml` and calling `.to_string()`, comments were included in the resulting string, causing validation to fail. This PR resolves the issue. ## Checklist <!-- Make sure all of these are complete --> - [x] Linked relevant issue - [x] Updated relevant documentation - [x] Added relevant tests - [x] Performed self-review of the code - [x] Added changes to `CHANGELOG.md` --------- Co-authored-by: Franciszek Job <[email protected]>
<!-- Reference any GitHub issues resolved by this PR --> I am happy to announce the first pr from our mailing list! 🔥🔥 Thanks Peter for your contribution ## Introduced changes <!-- A brief description of the changes --> - ## Checklist <!-- Make sure all of these are complete --> - [x] Linked relevant issue - [x] Updated relevant documentation - [x] Added relevant tests - [x] Performed self-review of the code - [x] Added changes to `CHANGELOG.md`
<!-- Reference any GitHub issues resolved by this PR --> Closes foundry-rs#2708 ## Introduced changes <!-- A brief description of the changes --> - Added default RPC providers to `sncast` under `--network` flag - Breaking: renamed `--network` flag to `--network-name` in `sncast account delete` and `sncast account import` due to conflict with the added flag ## Checklist <!-- Make sure all of these are complete --> - [x] Linked relevant issue - [x] Updated relevant documentation - [x] Added relevant tests - [x] Performed self-review of the code - [x] Added changes to `CHANGELOG.md` --------- Co-authored-by: Franciszek Job <[email protected]> Co-authored-by: kkawula <[email protected]>
- Update the link to fix failing docs build as here: https://github.com/foundry-rs/starknet-foundry/actions/runs/13019331002/job/36320971572
… omitted (foundry-rs#2888) <!-- Reference any GitHub issues resolved by this PR --> Closes # ## Introduced changes <!-- A brief description of the changes --> This came up from foundry-rs#2865 Conversion from `ScriptFeeSettings` to `FeeSettings` resulted in value for `max_fee` being dropped completely. This conversion was only in cast script "deploy" function. If deploy was used with Strk token, any value passed to `max_fee` was completely ignored. Removed the conversion entirely and used correct structure in deploy. ## Checklist <!-- Make sure all of these are complete --> - [x] Linked relevant issue - [x] Updated relevant documentation - [x] Added relevant tests - [x] Performed self-review of the code - [x] Added changes to `CHANGELOG.md`
<!-- Reference any GitHub issues resolved by this PR --> Closes foundry-rs#2851 ## Introduced changes <!-- A brief description of the changes --> - Added implementation for resolving environmental variables with curly braces ## Checklist <!-- Make sure all of these are complete --> - [x] Linked relevant issue - [x] Updated relevant documentation - [x] Added relevant tests - [x] Performed self-review of the code - [ ] Added changes to `CHANGELOG.md` --------- Co-authored-by: ddoktorski <[email protected]> Co-authored-by: Franciszek Job <[email protected]>
…-rs#2869) <!-- Reference any GitHub issues resolved by this PR --> Closes foundry-rs#2853 ## Introduced changes <!-- A brief description of the changes --> - Updated error to suggest using “--max-n-steps” in case of cairo_vm error ## Checklist <!-- Make sure all of these are complete --> - [x] Linked relevant issue - [x] Updated relevant documentation - [x] Added relevant tests - [x] Performed self-review of the code - [x] Added changes to `CHANGELOG.md` --------- Co-authored-by: kkawula <[email protected]> Co-authored-by: ddoktorski <[email protected]> Co-authored-by: Artur Michałek <[email protected]>
<!-- Reference any GitHub issues resolved by this PR --> Closes # ## Introduced changes <!-- A brief description of the changes --> - ## Checklist <!-- Make sure all of these are complete --> - [ ] Linked relevant issue - [ ] Updated relevant documentation - [ ] Added relevant tests - [ ] Performed self-review of the code - [ ] Added changes to `CHANGELOG.md`
<!-- Reference any GitHub issues resolved by this PR --> Closes foundry-rs#2816 Settings reference: https://github.com/actions/stale?tab=readme-ov-file#all-options ## Introduced changes <!-- A brief description of the changes --> - ## Checklist <!-- Make sure all of these are complete --> - [x] Linked relevant issue - [x] Updated relevant documentation - [x] Added relevant tests - [x] Performed self-review of the code - [x] Added changes to `CHANGELOG.md` --------- Co-authored-by: Artur Michałek <[email protected]>
franciszekjob
requested changes
Feb 3, 2025
|
@Nemezjusz Also, docs for |
ksew1
reviewed
Feb 3, 2025
franciszekjob
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2723
adding clean.rs and modifying lib.rs