Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes https get accept header when using Ruby version < 3.0 #286

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Removes https get accept header when using Ruby version < 3.0 #286

wants to merge 2 commits into from

Conversation

tilthouse
Copy link

This takes @lauratpa's original fix and adds tests — in this case easy to do since the calls that differ by Ruby version are all mocked.

@tilthouse tilthouse mentioned this pull request Aug 22, 2023
Open
@Rdx31
Copy link

Rdx31 commented Dec 16, 2023 •
edited
Loading

Hello @swinner2 / @fphilipe
I saw this PR is approved since August 22; any chance to get it merged and having a new release of premailer-rails before new year ? 🙏

Thanks for your help !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swinner2 swinner2 swinner2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tilthouse @Rdx31 @swinner2