update Skyland gba rom #30
Conversation
The last one was two years old and I've changed a lot of stuff since then
| }, | ||
| "playable": true | ||
| } | ||
| ], | ||
| "license": "MIT", | ||
| "license": "Custom", |
There was a problem hiding this comment.
I'm surprised this passes the schema validator, to be honest :/
Anyway, if I understood correctly now the game is basically "source-available" but not open source anymore so we can simply remove the "license field"? Or maybe ad a "source-available" option for it..
There was a problem hiding this comment.
I unfortunately had to change the license after dealing with issues with pirated bootleg cartridges, and licensing complaints from Steam, who do not like open source licenses that much. The MIT license, which applied to the jam version of the game, was later superseded by the GPL license, which I used until valve rejected my game submission. I would be fine with either removing the license field or labeling it as source available, let me know which you'd prefer and I'll fix my PR
There was a problem hiding this comment.
Shit, that sucks. I'd say, for the sake of keeping this PR in scope, removing the Open Source tag and the license field should be okay and we can merge it quickly. I can in parallel open an issue regarding changing the Schema to accomodate and expose "source-available" entries faithfully.
There was a problem hiding this comment.
While it's no longer open source, the current license allows modification and redistribution, the only limitation is on selling copies of the ROM. The license is still compatible with publishing on homebrew hub :)
There was a problem hiding this comment.
Yep, sure! But the entry shouldn't be listed there as "Open Source" anymore, no ?
There was a problem hiding this comment.
Yeah correct! I tried to update the checksums, the license field, and the other stuff in the game.json, please let me know if there's anything I can do to fix my PR, I am happy to make any changes that you suggest!
There was a problem hiding this comment.
Maybe by github ui is glitched? I see the license field still there (which we can remove) and the "Open Source" tag still in the tags?
There was a problem hiding this comment.
(I'd love to have "source available" / "custom" as possible values in "license" but the schema is not ready for it and pushing the entry as "custom" license would break the frontends, which atm expect SPDX identifiers..)
The last one was a couple of years old and I've changed a lot of stuff since then