Add a platform check to homebrew role #112
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow the use of this as a role dependency - Ansible executes role dependencies unconditionally, so it's not possible to add
geerlingguy.mac.homebrew
to thedependencies
section in a role'smeta.yml
if said role might run on non-macOS hosts (as Ansible will then try to install Homebrew on a non-macOS system, which unsurprisingly fails).With this change, the role itself will still execute when used as a dependency, but only runs its tasks if the host is indeed running macOS.
The other alternative would be to add the
ansible_os_family
check to every task in the role; however by having a singleinclude_tasks
main step with the check will return much more quickly on non-Mac hosts.