Minor: Force rotateEnabled() to always return a boolean. #1455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`_rotateEnabled` might not yet be initialized when calling `rotateEnabled`, returning `undefined` in that case. Adopting this pattern from other places such as `layerDragEnabled`.
Falke-Design
approved these changes
Feb 15, 2024
|
Thank you very much! |
|
awesome, thank you @Falke-Design for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_rotateEnabledmight not yet be initialized when callingrotateEnabled, returningundefinedin that case:leaflet-geoman/src/js/Mixins/Rotating.js
Line 225 in 7f388cc
Hence converting to boolean first. Adopting this pattern from other places such as
layerDragEnabled:leaflet-geoman/src/js/Mixins/Dragging.js
Line 133 in 7f388cc