feat(publish): Add allowlist for branches to take craft config from #3452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
commented
Feb 16, 2024
.github/workflows/publish.yml
Outdated
Comment on lines
48
to
49
| fromJSON(steps.inputs.outputs.result).repo == 'sentry-migr8' && fromJSON(steps.inputs.outputs.result).merge_target == 'main' || | ||
| fromJSON(steps.inputs.outputs.result).repo == 'sentry-migr8' && fromJSON(steps.inputs.outputs.result).merge_target == 'tmp-merge-target' |
There was a problem hiding this comment.
I opted to temporarily add an entry for sentry-migr8 here so that I can test this before we add e.g. the JS SDK repo.
There was a problem hiding this comment.
For sentry-migr8 it should be fine to cut a few releases as it's still just a hackweek project at the moment
To test, I removed the npm target. We can even clean up the GH release afterwards.
There was a problem hiding this comment.
let's add branch protection to that repo just so we're following the process
There was a problem hiding this comment.
This was referenced Feb 16, 2024
.github/workflows/publish.yml
Outdated
| - name: Set target repo checkout branch | ||
| # Note: Branches registered here MUST BE protected in the target repo! | ||
| if: | | ||
| fromJSON(steps.inputs.outputs.result).repo == 'sentry-migr8' && fromJSON(steps.inputs.outputs.result).merge_target == 'main' || |
There was a problem hiding this comment.
I think this first one wouldn't be needed since this is the default branch?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a step to the
publish.ymlworkflow that determines which branch of the target repo should be checked out.The checked out branch will be the one where craft takes its config from.
By default, we always check out the target repo's default branch.
ref #3441