Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(publish): Add sentry-javascript/master branch to target-repo-branch step #3469

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Feb 21, 2024

This PR adds the master branch to the allowed branches we can take the craft config file from in sentry-javascript.
IMHO we should allow taking the config from master as well as from v7 (as done in #3467):

  • Our repo's default branch is develop while we release from master (more information on our gitflow approach). So there is a chance that the craft config on develop is not aligned with the config on master, for instance in the case where the config is changed while a release is still in progress.
  • I'd like to avoid using two different strategies of obtaining the craft config (i.e. once via the new opt in mechanism, once in the default way), which 1. increases consistency and 2. makes it easier for everyone on the team and surrounding teams to create releases, regardless of v7 or current version (v8)
  • Branch protection rules for master and develop are aligned, so this requirement should be fulfilled.

@Lms24 Lms24 force-pushed the lms/feat-add-sentry-javascript-master-to-merge-target-branch-checkout branch from 6af23f8 to 829ffdd Compare February 21, 2024 16:10
@Lms24 Lms24 marked this pull request as ready for review February 21, 2024 16:16
@Lms24 Lms24 requested a review from a team as a code owner February 21, 2024 16:16
Copy link
Member

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile-sentry asottile-sentry merged commit c64df9c into getsentry:main Feb 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants