fix: Fix target parsing and emitting for publish issues #5026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lforst
changed the title
|
can you rebase out the style changes -- it's making it difficult to review your patch |
|
@asottile-sentry sure thing |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes parsing of checked/unchecked targets in the publish issues.
For release #5025 we noticed that checking checkboxes didn't work and it was due to faulty regexes in the logic that "parsed" the github issue. More concretely, the regexes didn't account for
@characters. This PR relaxes the regex to interpret any sequence of non-whitespace characters as the target ID when parsing.