Skip to content

Commit

Permalink
use different e2e log check
Browse files Browse the repository at this point in the history
  • Loading branch information
lucas-zimerman committed Feb 3, 2025
1 parent de0a0d8 commit b037484
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions scripts/check-siblings.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const updateArgument = '--update-sentry-capacitor';
// Filters all Sentry packages but Capacitor, CLI and Wizard.
const jsonFilter = /\s*\"\@sentry\/(?!capacitor|wizard|cli|typescript|electron)(?<packageName>[a-zA-Z]+)\"\:\s*\"(?<version>.+)\"/;

const IsE2E = env.npm_package_scripts_test_e2e == './scripts/e2e-test.siblings.sh';
const IsE2E = env.sentry_e2e == 'true';

function LogE2E(message) {
IsE2E && console.log("E2E_TEST: " + message);
Expand Down Expand Up @@ -138,7 +138,6 @@ function CheckSiblings() {
if (env.npm_config_argv) {
// Only available on Yarn.
const npmAction = JSON.parse(env.npm_config_argv);

if (npmAction.original && npmAction.original.length > 1) {
ValidateSentryPackageParameters(npmAction.original, siblingVersion);
LogE2E("OK");
Expand Down
2 changes: 1 addition & 1 deletion test/scripts/check-siblingsHelper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ export function InstallSDK(pkgMnger: string, args: ReadonlyArray<string>, rootPa

const newEnv = {
PATH: HideGlobalYarnPath(),
npm_package_scripts_test_e2e: process.env.npm_package_scripts_test_e2e,
sentry_e2e: 'true',
...nodePatch,
INIT_CWD: rootPath // Override INIT_CWD to match the desired root path
};
Expand Down

0 comments on commit b037484

Please sign in to comment.