Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v9]: Remove screenshot option attachScreenshotOnlyWhenResumed #2664

Merged
merged 6 commits into from
Feb 10, 2025

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Feb 5, 2025

📜 Description

Remove screenshot option attachScreenshotOnlyWhenResumed

💡 Motivation and Context

Closes #2639

💚 How did you test it?

CI

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.50%. Comparing base (79ccefb) to head (bbc70b9).
Report is 214 commits behind head on v9.

Additional details and impacted files
@@             Coverage Diff             @@
##               v9    #2664       +/-   ##
===========================================
+ Coverage   67.94%   92.50%   +24.55%     
===========================================
  Files          15       90       +75     
  Lines         443     2908     +2465     
===========================================
+ Hits          301     2690     +2389     
- Misses        142      218       +76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denrase denrase marked this pull request as ready for review February 5, 2025 14:31
# Conflicts:
#	flutter/lib/src/sentry_flutter_options.dart
@denrase denrase merged commit 496768f into v9 Feb 10, 2025
59 of 60 checks passed
@denrase denrase deleted the v9-remove-screenshot-attach-only-when-resumed branch February 10, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants