Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v9]: remove manual TTID #2668

Merged
merged 5 commits into from
Feb 10, 2025
Merged

[v9]: remove manual TTID #2668

merged 5 commits into from
Feb 10, 2025

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Feb 6, 2025

📜 Description

💡 Motivation and Context

v9 Task

💚 How did you test it?

Closes #2636

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.41%. Comparing base (e02b3d6) to head (3197068).
Report is 2 commits behind head on v9.

Additional details and impacted files
@@            Coverage Diff             @@
##               v9    #2668      +/-   ##
==========================================
+ Coverage   89.09%   92.41%   +3.32%     
==========================================
  Files         262       89     -173     
  Lines        8882     2886    -5996     
==========================================
- Hits         7913     2667    -5246     
+ Misses        969      219     -750     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buenaflor buenaflor marked this pull request as ready for review February 6, 2025 13:36
@buenaflor buenaflor requested a review from denrase February 6, 2025 13:36
Copy link
Collaborator

@denrase denrase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Can we remove manualUiTimeToDisplay from SentryTraceOrigins?

@buenaflor
Copy link
Contributor Author

@denrase that origin is still relevant for TTFD

@buenaflor buenaflor merged commit ce53819 into v9 Feb 10, 2025
64 checks passed
@buenaflor buenaflor deleted the task/remove-sentry-display-widget branch February 10, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants