-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Automate release flow #45
Conversation
Adapted from sentry-unreal.
b8055e5
to
a5231b6
Compare
1b6e28b
to
3935d88
Compare
Adapted from sentry-unity.
I think this is as close as I could get without actually testing with real tokens and creating a release. I can also add registry to the configuration: - name: registry
sdks:
github:getsentry/sentry-godot: I'm not sure what else is needed for the registry to work. |
- name: Prepare artifact | ||
shell: bash | ||
run: | | ||
# * Fix crashpad_handler permissions, workaround for https://github.com/actions/upload-artifact/issues/38 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally this goes into a script so it's easier to test locally and debug stuff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It relies on actually downloading an artifact - something that is a merged product of a number of builds. Testing it locally would be cumbersome, since it's not enough to produce a single build for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant the steps. There are a few commands here that could go in a .sh
file and we invoke it from here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add:
Unreleased
This will get replaced with the version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not showing on the diff yet, did you push it?
Release registry requires that we create the first version "by hand". |
This is a test build run in my fork: https://github.com/limbonaut/sentry-godot/actions/runs/12354096820 |
In such a case, we can add it later, after the first release and adding this metadata "by hand". Or should we create the first |
- name: Prepare artifact | ||
shell: bash | ||
run: | | ||
# * Fix crashpad_handler permissions, workaround for https://github.com/actions/upload-artifact/issues/38 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant the steps. There are a few commands here that could go in a .sh
file and we invoke it from here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not showing on the diff yet, did you push it?
changelogPolicy: auto | ||
preReleaseCommand: pwsh scripts/bump-version.ps1 | ||
targets: | ||
- name: github |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're not using release registry here, this PR is unblocked.
On a follow up PR, we can add a new target, like this:
https://github.com/getsentry/sentry-unreal/blob/4027d198c6ab87016d95665fcf9af1df3cac4a31/.craft.yml#L12-L13
But basically as:
- name: registry
sdks:
github:getsentry/sentry-godot:
That is, once this is merged: getsentry/sentry-release-registry#174
I merged to test it out since it requires approval anyway once a release is triggered. Triggering here as 0.0.1 (since we're not pushing to the release registry yet, since I already created 0.0.1 there). Run: https://github.com/getsentry/sentry-godot/actions/runs/12404236789/job/34629077725 But failed with:
Seems to be described on this issue:
I'll create a dummy tag: https://github.com/getsentry/sentry-godot/releases/tag/0.0.0 Rerunning the workflow: https://github.com/getsentry/sentry-godot/actions/runs/12404236789 Approval issue created: getsentry/publish#4791 version going from 0.1.0-dev to 0.0.1 which is fine for this test: 2ea6be3...refs/heads/release/0.0.1 Release logs: https://github.com/getsentry/publish/actions/runs/12404320280/job/34629296353 Failed: getsentry/publish#4791 (comment) |
See comment getsentry/publish#4791 (comment) |
Included:
Closes #30