-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4] Move the Flags group over to the tox gen script #3974
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but see comment
@@ -754,6 +739,15 @@ deps = | |||
# These come from the populate_tox.py script. Eventually we should move all | |||
# integration tests there. | |||
|
|||
# ~~~ Flags ~~~ | |||
launchdarkly-v9.8.1: launchdarkly-server-sdk==9.8.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the script pull 9.8.0 instead of 9.8.1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It only considers the highest micro version of each release
openfeature
,launchdarkly
, andunleash
from the tox templatepopulate_tox.py
populate_tox.py
to fill in entries for themsplit_gh_tox_actions.py
to generate the CI yaml files so that they correspond to the newtox.ini
Note that this effectively eliminates the
-latest
tests for the Flags group. The script doesn't generate any-latest
tests since it always makes sure to add a pinned entry for the latest version. So in case all of the integrations in a single group are using the script, the whole-latest
test category is removed.