Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tracing): Store sample_rand in DSC #4016

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

szokeasaurusrex
Copy link
Member

Closes #3998

@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/sample-rand branch from 7fc76f6 to f50c9af Compare February 3, 2025 16:17
Copy link

codecov bot commented Feb 3, 2025

❌ 109 Tests Failed:

Tests completed Failed Passed Skipped
23173 109 23064 5720
View the top 3 failed tests by shortest run time
tests.integrations.httpx.test_httpx test_outgoing_trace_headers_append_to_baggage[httpx_client0]
Stack Traces | 0.051s run time
.../integrations/httpx/test_httpx.py:135: in test_outgoing_trace_headers_append_to_baggage
    assert (
E   AssertionError: assert 'custom=data,sentry-trace_id=01234567890123456789012345678901,sentry-sample_rand=0.07190396862619497,sentry-environment=production,sentry-release=d08ebdb9309e1b004c6f52202de58a09c2268e42,sentry-transaction=............/interactions/other-dogs/new-dog,sentry-sample_rate=1.0,sentry-sampled=true' == 'custom=data,sentry-trace_id=01234567890123456789012345678901,sentry-environment=production,sentry-release=d08ebdb9309e1b004c6f52202de58a09c2268e42,sentry-transaction=............/interactions/other-dogs/new-dog,sentry-sample_rate=1.0,sentry-sampled=true'
E     - custom=data,sentry-trace_id=01234567890123456789012345678901,sentry-environment=production,sentry-release=d08ebdb9309e1b004c6f52202de58a09c2268e42,sentry-transaction=............/interactions/other-dogs/new-dog,sentry-sample_rate=1.0,sentry-sampled=true
E     + custom=data,sentry-trace_id=01234567890123456789012345678901,sentry-sample_rand=0.07190396862619497,sentry-environment=production,sentry-release=d08ebdb9309e1b004c6f52202de58a09c2268e42,sentry-transaction=............/interactions/other-dogs/new-dog,sentry-sample_rate=1.0,sentry-sampled=true
E     ?                                                                     +++++++++++++++++++++++++++++++++++++++
tests.integrations.httpx.test_httpx test_outgoing_trace_headers_append_to_baggage[httpx_client1]
Stack Traces | 0.051s run time
.../integrations/httpx/test_httpx.py:135: in test_outgoing_trace_headers_append_to_baggage
    assert (
E   AssertionError: assert 'custom=data,sentry-trace_id=01234567890123456789012345678901,sentry-sample_rand=0.07190396862619497,sentry-environment=production,sentry-release=d08ebdb9309e1b004c6f52202de58a09c2268e42,sentry-transaction=............/interactions/other-dogs/new-dog,sentry-sample_rate=1.0,sentry-sampled=true' == 'custom=data,sentry-trace_id=01234567890123456789012345678901,sentry-environment=production,sentry-release=d08ebdb9309e1b004c6f52202de58a09c2268e42,sentry-transaction=............/interactions/other-dogs/new-dog,sentry-sample_rate=1.0,sentry-sampled=true'
E     - custom=data,sentry-trace_id=01234567890123456789012345678901,sentry-environment=production,sentry-release=d08ebdb9309e1b004c6f52202de58a09c2268e42,sentry-transaction=............/interactions/other-dogs/new-dog,sentry-sample_rate=1.0,sentry-sampled=true
E     + custom=data,sentry-trace_id=01234567890123456789012345678901,sentry-sample_rand=0.07190396862619497,sentry-environment=production,sentry-release=d08ebdb9309e1b004c6f52202de58a09c2268e42,sentry-transaction=............/interactions/other-dogs/new-dog,sentry-sample_rate=1.0,sentry-sampled=true
E     ?                                                                     +++++++++++++++++++++++++++++++++++++++
tests.integrations.celery.test_celery test_baggage_propagation
Stack Traces | 0.053s run time
.../integrations/celery/test_celery.py:520: in test_baggage_propagation
    assert sorted(result["baggage"].split(",")) == sorted(
E   AssertionError: assert ['custom=value', 'sentry-environment=production', 'sentry-release=abcdef', 'sentry-sample_rand=0.8445520012161253', 'sentry-sample_rate=1.0', 'sentry-sampled=true', 'sentry-trace_id=bc87f5400b104152a897b3ea27b3c1bf'] == ['custom=value', 'sentry-environment=production', 'sentry-release=abcdef', 'sentry-sample_rate=1.0', 'sentry-sampled=true', 'sentry-trace_id=bc87f5400b104152a897b3ea27b3c1bf']
E     At index 3 diff: 'sentry-sample_rand=0.8445520012161253' != 'sentry-sample_rate=1.0'
E     Left contains one more item: 'sentry-trace_id=bc87f5400b104152a897b3ea27b3c1bf'
E     Full diff:
E       [
E        'custom=value',
E        'sentry-environment=production',
E        'sentry-release=abcdef',
E     +  'sentry-sample_rand=0.8445520012161253',
E        'sentry-sample_rate=1.0',
E        'sentry-sampled=true',
E        'sentry-trace_id=bc87f5400b104152a897b3ea27b3c1bf',
E       ]

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Sampling Seed Propagation
1 participant