feat(tracing): Use sample_rand for sampling decisions
#4044
+154
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## szokeasaurusrex/sample_rand-3 #4044 +/- ##
=================================================================
+ Coverage 80.30% 80.31% +0.01%
=================================================================
Files 139 139
Lines 15452 15462 +10
Branches 2613 2615 +2
=================================================================
+ Hits 12409 12419 +10
+ Misses 2203 2202 -1
- Partials 840 841 +1
|
szokeasaurusrex
force-pushed
the
szokeasaurusrex/sample_rand-4
branch
from
c3d6d12 to
5a906f6
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/sample_rand-3
branch
from
af64b16 to
01334d7
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/sample_rand-4
branch
from
5a906f6 to
548396d
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/sample_rand-3
branch
from
01334d7 to
7ec8e08
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/sample_rand-4
branch
4 times, most recently
from
c4abdc9 to
5f57723
Compare
sentrivana
reviewed
Feb 13, 2025
Comment on lines
+806
to
+810
| if baggage_sample_rand is not None: | ||
| self._sample_rand = baggage_sample_rand | ||
| else: | ||
| self._sample_rand = Random(self.trace_id).random() |
There was a problem hiding this comment.
In what cases will we have to generate a new _sample_rand here?
There was a problem hiding this comment.
Whenever we are starting a new trace, i.e. if we call start_transaction without calling continue_trace first and without manually passing in baggage
Use the `sample_rand` value from an incoming trace to make sampling decisions, rather than generating a random value. When we are the head SDK starting a new trace, save our randomly-generated value as the `sample_rand`, and also change the random generation logic so that the `sample_rand` is computed deterministically based on the `trace_id`. Closes #3998
szokeasaurusrex
force-pushed
the
szokeasaurusrex/sample_rand-4
branch
from
5f57723 to
b66c955
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/sample_rand-3
branch
from
7ec8e08 to
b400fb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
sample_randvalue from an incoming trace to make sampling decisions, rather than generating a random value. When we are the head SDK starting a new trace, save our randomly-generated value as thesample_rand, and also change the random generation logic so that thesample_randis computed deterministically based on thetrace_id.Depends on:
sample_randonPropagationContext#4038Closes #3998
Thank you for contributing to
sentry-python! Please add tests to validate your changes, and lint your code usingtox -e linters.Running the test suite on your PR might require maintainer approval. The AWS Lambda tests additionally require a maintainer to add a special label, and they will fail until this label is added.