feat(bitbucket): check bitbucket webhook signature if webhook_secret is defined #84309
+120
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
This was referenced Jan 30, 2025
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #84309 +/- ##
===========================================
+ Coverage 46.61% 87.66% +41.05%
===========================================
Files 9563 9575 +12
Lines 541874 542418 +544
Branches 21264 21252 -12
===========================================
+ Hits 252589 475535 +222946
+ Misses 288933 66531 -222402
Partials 352 352 |
cathteng
approved these changes
Jan 30, 2025
| @@ -206,6 +262,6 @@ def post(self, request: HttpRequest, organization_id: int) -> HttpResponse: | |||
| domain=IntegrationDomain.SOURCE_CODE_MANAGEMENT, | |||
| provider_key=event_handler.provider, | |||
| ).capture(): | |||
| event_handler(event, organization=organization) | |||
| event_handler(event, request=request, organization=organization) | |||
There was a problem hiding this comment.
what do we need the request for here? it's not being used in BitbucketWebhook except to check that it's passed
There was a problem hiding this comment.
request contains X-Hub-Signature header and request body which are used here:
sentry/src/sentry/integrations/bitbucket/webhook.py
Lines 135 to 142 in 90fc14b
There was a problem hiding this comment.
oh wait, can we do this in the webhook itself before calling the handler?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparing Bitbucket webhook secret validation. This is actual signature header validation, but no integrations/repos have the associated secret yet.
Follow-up PRs:
webhook_secret: feat(bitbucket): add webhook secret on each repository creation #84311Previous attempt (#82541) had repository-level secrets but we decided to go with integration-level secret to align with other integrations (GitLab, GitHub).