ref(derived_code_mappings): Refactor endpoint #84318
Draft
+126
−121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also makes the code less coupled to the GitHub integration.
github-actions
bot
added
the
Scope: Backend
armenzg
commented
Jan 30, 2025
| @@ -286,29 +285,6 @@ def has_repo_access(self, repo: RpcRepository) -> bool: | |||
| return False | |||
| return True | |||
|
|
|||
| # XXX: To be removed after we switch over to the new repo trees integration code | |||
| def get_trees_for_org_old(self, cache_seconds: int = 3600 * 24) -> dict[str, RepoTree]: | |||
There was a problem hiding this comment.
I should have removed this in #84164
| @@ -45,6 +48,23 @@ class UnsupportedFrameFilename(Exception): | |||
| pass | |||
|
|
|||
|
|
|||
| def derive_code_mappings( | |||
There was a problem hiding this comment.
This is the code the endpoint is going to call.
Eventually, I will unify this code and the one the task calls.
| SUPPORTED_INTEGRATIONS = ["github"] | ||
|
|
||
|
|
||
| def get_installation( |
There was a problem hiding this comment.
This function comes from the task module but it needs to be shared.
| @@ -71,6 +73,9 @@ def process_event(project_id: int, group_id: int, event_id: str) -> None: | |||
| logger.info("No installation or organization integration found.", extra=extra) | |||
| return | |||
|
|
|||
| if not isinstance(installation, RepoTreesIntegration): | |||
There was a problem hiding this comment.
This class is what gives an integration the get_trees_for_org method.
| @@ -184,30 +189,6 @@ def get_stacktrace(data: NodeData) -> list[Mapping[str, Any]]: | |||
| return [] | |||
|
|
|||
|
|
|||
| def get_installation( | |||
There was a problem hiding this comment.
Moved to a shared module.
There was a problem hiding this comment.
I'm moving code from here into the code_mapping module.
| resp_status: Literal[200, 204, 400] = status.HTTP_400_BAD_REQUEST | ||
|
|
||
| if stacktrace_filename: | ||
| possible_code_mappings = derive_code_mappings(organization, stacktrace_filename) |
There was a problem hiding this comment.
All code mapping-related code has been moved within this call.
❌ 27 Tests Failed:
View the top 3 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also makes the code less coupled to the GitHub integration.