-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Trace Root transaction name #612
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@spotlightjs/overlay': patch | ||
--- | ||
|
||
Added Trace root transaction name in Trace detail header |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
...ntegrations/sentry/components/explore/traces/TraceDetails/components/TraceRootTxnName.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
import type { Trace } from '~/integrations/sentry/types'; | ||
import Tag from '~/ui/Tag'; | ||
|
||
export function TraceRootTxnName({ trace, flowing = false }: { trace: Trace; flowing?: boolean }) { | ||
const method = String( | ||
trace.rootTransaction?.contexts?.trace.data?.method || trace.rootTransaction?.request?.method || '', | ||
); | ||
const name = | ||
method && trace.rootTransactionName.startsWith(method) | ||
? trace.rootTransactionName.slice(method.length + 1) | ||
: trace.rootTransactionName; | ||
return <Tag tagKey={method} value={name} flowing={flowing} />; | ||
} | ||
Check warning on line 13 in packages/overlay/src/integrations/sentry/components/explore/traces/TraceDetails/components/TraceRootTxnName.tsx
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,30 @@ | ||
export type TagProps = { tagKey: string; value: string }; | ||
import classNames from '~/lib/classNames'; | ||
|
||
export default function Tag({ tagKey, value }: TagProps) { | ||
return value ? ( | ||
<div className="border-primary-300 bg-primary-900 divide-x-primary-300 inline-flex divide-x overflow-hidden whitespace-nowrap rounded-full border font-mono text-sm"> | ||
{tagKey ? <div className="px-2 py-1 font-semibold">{tagKey}</div> : null} | ||
<div className="bg-primary-800 rounded-full px-2 py-1">{value}</div> | ||
export type TagProps = { | ||
tagKey?: string; | ||
value: string; | ||
flowing?: boolean; | ||
maxWidth?: string; | ||
}; | ||
|
||
export default function Tag({ tagKey, value, flowing = false, maxWidth = '400px' }: TagProps) { | ||
if (!value) return null; | ||
|
||
return ( | ||
<div | ||
className={classNames( | ||
'border-primary-300 bg-primary-900 divide-x-primary-300 inline-flex divide-x overflow-hidden whitespace-nowrap rounded-full border font-mono text-sm', | ||
flowing && 'max-w-full', | ||
)} | ||
> | ||
{tagKey && <div className="px-2 py-1 font-semibold">{tagKey}</div>} | ||
<div | ||
title={value} | ||
className={classNames('bg-primary-800 truncate px-2 py-1', flowing ? 'max-w-full' : 'max-w-none')} | ||
style={{ maxWidth: flowing ? '100%' : maxWidth }} | ||
> | ||
{value} | ||
</div> | ||
</div> | ||
) : null; | ||
); | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need the two
spaces here? 😅There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah just to give some space between tag and "Trace:"