Notification target contract add tags #17248
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding notice time and end time for contract notifications. Before, there was just one "time" tag and no possibility to print the end time on notice and vice-versa.
(correct spaces and remove tabs)
spaces removed
|
Hello @cedric-anne sorry that I left this here for so long time, but it is still actual for me, and surely also for others that need to write complete notifications for contracts. Would it be possiblle to re-run the checks? There are no more details visible on what has failed in the two checks that were not successful. |
|
You'd better rebase your branch on an up-to-date 10.0/bugfixes; this will trigger tests. |
|
Sorry @trasher now I updated to the main branch and all 2000 commits are shown here. |
I've updated target branch on the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For contract notifications, there is actually only one Tag contract.time that holds either the notice time or the end time.
However it is also sometimes needed to write both dates. This modification adds the contract.noticetime and contract.endtime Tags. The labels used are the ones already in use and thus translated. The tags are shown also on the tags helper page when editing the notification template.