Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings detected by e2e tests #18208

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Fix warnings detected by e2e tests #18208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Glpi/Form/QuestionType/QuestionTypeDropdown.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ public function renderAdministrationTemplate(?Question $question): string

<div data-glpi-form-editor-preview-dropdown>
{{ fields.dropdownArrayField(
'',
'default_value',
checked_values|first,
values,
'',
Expand All @@ -141,7 +141,7 @@ public function renderAdministrationTemplate(?Question $question): string
}
) }}
{{ fields.dropdownArrayField(
'',
'default_value',
'',
values,
'',
Expand Down
4 changes: 2 additions & 2 deletions src/Glpi/Form/QuestionType/QuestionTypeUserDevice.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ public function renderAdministrationTemplate(?Question $question): string
{% import 'components/form/fields_macros.html.twig' as fields %}

{{ fields.dropdownArrayField(
'',
'default_value',
'',
[],
'',
Expand All @@ -98,7 +98,7 @@ public function renderAdministrationTemplate(?Question $question): string
) }}

{{ fields.dropdownArrayField(
'',
'default_value',
'',
[],
'',
Expand Down
1 change: 1 addition & 0 deletions tests/cypress/e2e/form/question_types/item.cy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ describe('Item form question type', () => {

cy.createWithAPI('Ticket', {
'name': 'Test ticket',
'content': '',
}).as('ticket_id');

cy.login();
Expand Down
4 changes: 3 additions & 1 deletion tests/cypress/e2e/itil_followups.cy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@
describe("ITIL Followups", () => {
it("can add a followup to a new ticket", () => {
cy.createWithAPI("Ticket", {
name: "Open ticket"
name: "Open ticket",
content: "",
}).then((id) => {
cy.login();
cy.visit(`/front/ticket.form.php?id=${id}`);
Expand All @@ -45,6 +46,7 @@ describe("ITIL Followups", () => {
it("can't add a followup to a closed ticket", () => {
cy.createWithAPI("Ticket", {
name: "Closed ticket",
content: "",
status: 6,
}).then((id) => {
cy.login();
Expand Down