Feature: add pre-release hook #187
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a hook just prior to creating a release.
My use-case for this is a desire to trigger a build of a code-base, units tests and other tests before release. This allows one to do minimal amount of work after the release has been created, and thus also allows one to not have to deal with rolling back a release should that code fail for whatever reason.
If this PR is approved, I intend to add support for this hook to the
execplugin as well.Notes:
PreReleasedoes describe what the hook does, but it also might be confusing as it clashes with the prerelease concept from SemVer. Let me know if another name should be used.scripts/generate.shscript because I couldn't find the similar versions of protoc, protoc-gen-go and protoc-gen-go-grpc easily. I tried with the latest versions and the code seems to compile fine, but there's a lot of changes introduced. Let me know if there's some other way you usually run the script, if I should generate using latest versions or if I should spend time sourcing the right versions.