-
-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Memory leak in BottomSheetBackdrop #1167
base: v4
Are you sure you want to change the base?
Conversation
Fix Memory leak in BottomSheetBackdrop that occurs when the backdrop tries to set the `pointerEvents` to `none` when dismissing the modal even though we don't need to. If the `disappearsOnIndex` is set to `-1` and the `animatedIndex` is `<= -1` , there is no need to call `setEventPointers` since the modal should be removed.
here's the patch if anyone is interested:
|
using local patch until we wait for this to get merged, @gorhom appreciate when you have some time to review it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @tsukudabuddha
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
@gorhom waiting for this PR to be merged. |
In my experience this fix prevents the bottom-sheet from opening on the first try. This pull request needs to be developed. Be careful before use. |
@tsukudabuddha thanks for submitting this PR, do you have a detailed issue reported i could verify the fix with? |
Motivation
pointerEvents
tonone
when dismissing the modal. If thedisappearsOnIndex
is set to-1
and theanimatedIndex
is<= -1
, there is no need to callsetEventPointers
since the modal should be removed.