Skip to content

Commit

Permalink
feat(npm-event): pass license and publisher to registry-change
Browse files Browse the repository at this point in the history
  • Loading branch information
hulkoba committed Jun 25, 2019
1 parent a48baff commit d292cb7
Show file tree
Hide file tree
Showing 2 changed files with 29 additions and 6 deletions.
4 changes: 1 addition & 3 deletions lib/npm-event.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
const crypto = require('crypto')

const _ = require('lodash')

const rollbar = require('./rollbar')

module.exports = npmEvent
Expand Down Expand Up @@ -43,7 +41,7 @@ function npmEvent (server, { env, channel }, next) {
try {
parsedPayload = JSON.parse(payload.toString()).payload
distTags = parsedPayload['dist-tags']
versions = _.mapValues(parsedPayload.versions, v => _.pick(v, ['gitHead', 'repository']))
versions = _.mapValues(parsedPayload.versions, version => _.pick(version, ['gitHead', 'repository', 'license', '_npmUser']))
} catch (e) {
return reply({ error: true }).code(401)
}
Expand Down
31 changes: 28 additions & 3 deletions test/npm-event.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,21 @@ const register = require('../lib/npm-event')
latest: '1.0.0'
},
versions: {
'1.0.0': {}
'1.0.0': {
'repository': {
type: 'git',
url: 'git+https://github.com/lodash/lodash.git'
},
'license': 'MIT',
'_npmUser': {
name: 'jdalton',
email: '[email protected]'
},
'contributors': {},
'bugs': {},
'keywords': [],
'author': {}
}
}
} })

Expand All @@ -78,7 +92,6 @@ const register = require('../lib/npm-event')
},
payload: reqPayload
})

t.is(statusCode, 202, 'statusCode')
t.true(JSON.parse(payload).ok, 'payload')

Expand All @@ -88,7 +101,19 @@ const register = require('../lib/npm-event')
dependency: '@test/test',
installation,
distTags: { latest: '1.0.0' },
versions: { '1.0.0': {} },
versions: {
'1.0.0': {
'repository': {
type: 'git',
url: 'git+https://github.com/lodash/lodash.git'
},
'license': 'MIT',
'_npmUser': {
name: 'jdalton',
email: '[email protected]'
}
}
},
registry: 'https://registry.npmjs.com'
}, 'job data')
t.same(job.properties.priority, 1, 'job priority')
Expand Down

0 comments on commit d292cb7

Please sign in to comment.