Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update yarn to latest stable version #307

Merged
merged 8 commits into from
May 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
LAST_TEAMCITY_BUILD=650
echo "BUILD_NUMBER=$(( $GITHUB_RUN_NUMBER + $LAST_TEAMCITY_BUILD ))" >> $GITHUB_ENV

- uses: actions/checkout@v3
- uses: actions/checkout@v4

# Setup AWS credentials to enable uploading to S3 for Riff-Raff.
# See https://github.com/aws-actions/configure-aws-credentials
Expand All @@ -31,16 +31,18 @@ jobs:
role-to-assume: ${{ secrets.GU_RIFF_RAFF_ROLE_ARN }}
aws-region: eu-west-1

- run: corepack enable

- name: Setup Node
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version-file: ".nvmrc"

- name: install dependencies
run: yarn install

- name: check for duplicate dependencies (if it fails here, then pre-commit hook is not working)
run: yarn yarn-deduplicate --fail
run: yarn dedupe --check

- name: generate TS definitions for GraphQL schema
run: yarn graphql-refresh
Expand Down
9 changes: 9 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,12 @@ cdk.out/

shared/graphql/graphql.ts
.DS_Store

# See https://yarnpkg.com/getting-started/qa#which-files-should-be-gitignored
.pnp.*
.yarn/*
!.yarn/patches
!.yarn/plugins
!.yarn/releases
!.yarn/sdks
!.yarn/versions
3 changes: 2 additions & 1 deletion .husky/pre-commit
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

set -e

corepack enable
yarn lint-staged

if (git diff --name-only --cached | grep -e 'cdk' -e 'shared/graphql'); then
Expand All @@ -11,7 +12,7 @@ if (git diff --name-only --cached | grep -e 'cdk' -e 'shared/graphql'); then
fi

if (git diff --name-only --cached | grep 'yarn.lock'); then
yarn yarn-deduplicate
yarn dedupe
git add yarn.lock
yarn workspace client analyze-main-client-bundle
fi
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18.15.0
18.20.2
Loading