Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Banner to Orgs on Homepage #149

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Added Banner to Orgs on Homepage #149

wants to merge 12 commits into from

Conversation

thedev132
Copy link
Collaborator

Summary of the problem

They were not skibidi sigma without the background image banner

Describe your changes

now it is skibidi sigma!!!

Checklist

  • Descriptive PR title (Does the title explain the changes in a concise manner?)
  • Tag related issues so they auto-close on merge
  • Easily digestible commits (Are the commits small and easy to understand?) video
  • CI passes (Do the GitHub checks pass?)
  • Tested by submitter before requesting review (Does it work in development iOS/android? )

@thedev132 thedev132 added the enhancement New feature or request label Jan 25, 2025
@thedev132 thedev132 self-assigned this Jan 25, 2025
@thedev132 thedev132 requested a review from a team as a code owner January 25, 2025 05:46
Copy link

github-actions bot commented Jan 25, 2025

🚀 Expo preview is ready!

  • Project → hcb-mobile
  • Platforms → android, ios
  • Scheme → hcb
  • Runtime Version → 1.0.0
  • More info

Learn more about 𝝠 Expo Github Action

@thedev132 thedev132 marked this pull request as draft January 25, 2025 06:41
@thedev132 thedev132 marked this pull request as ready for review January 25, 2025 21:59
Copy link
Collaborator

@Luke-Oldenburg Luke-Oldenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The organization cards should be the same aspect ratio as on the website especially with banners imo.

@thedev132
Copy link
Collaborator Author

I'm kinda against that as I wanna keep them as small cards so you can easily access organizations as people with many would have to start scrolling through a lot.

@Luke-Oldenburg
Copy link
Collaborator

Luke-Oldenburg commented Feb 2, 2025

@thedev132 can the size at least be standardized? Not all of the cards are sized the same. Also for most people they probably have the same amount of HCB cards or more HCB cards than the amount of organizations they are in and those are sized larger (obviously for realism but point still stands).

@Luke-Oldenburg
Copy link
Collaborator

Also, the background had ought to be tinted darker so you can read the organization name still. Site CSS appears to be this although I may have gotten the wrong class:

.card.card--background-image {
  background-image: linear-gradient(rgba(37,36,41,.5) 0,rgba(37,36,41,.85) 75%),var(--bg-image);

}

@thedev132
Copy link
Collaborator Author

@Luke-Oldenburg Thanks for code was looking for that tint lol. As for the standardized size, they all are usually pretty much the same with exceptions of multi lined organization names. If it's not that idk and a visual might help :)

@Luke-Oldenburg
Copy link
Collaborator

It appears if they don't have a background set they are smaller. Also, should we be truncating those names as we do on HCB cards to standardize size?

@thedev132
Copy link
Collaborator Author

Hey if you could show me that’d be better.

@Luke-Oldenburg
Copy link
Collaborator

IMG_5671

@thedev132
Copy link
Collaborator Author

Just fixed that issue! As for banner tints, those values are way darker than what i gave. If you wanna fix it could u provide me with some better gradients :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants