-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Banner to Orgs on Homepage #149
base: main
Are you sure you want to change the base?
Conversation
🚀 Expo preview is ready!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The organization cards should be the same aspect ratio as on the website especially with banners imo.
I'm kinda against that as I wanna keep them as small cards so you can easily access organizations as people with many would have to start scrolling through a lot. |
@thedev132 can the size at least be standardized? Not all of the cards are sized the same. Also for most people they probably have the same amount of HCB cards or more HCB cards than the amount of organizations they are in and those are sized larger (obviously for realism but point still stands). |
Also, the background had ought to be tinted darker so you can read the organization name still. Site CSS appears to be this although I may have gotten the wrong class: .card.card--background-image {
background-image: linear-gradient(rgba(37,36,41,.5) 0,rgba(37,36,41,.85) 75%),var(--bg-image);
} |
@Luke-Oldenburg Thanks for code was looking for that tint lol. As for the standardized size, they all are usually pretty much the same with exceptions of multi lined organization names. If it's not that idk and a visual might help :) |
It appears if they don't have a background set they are smaller. Also, should we be truncating those names as we do on HCB cards to standardize size? |
Hey if you could show me that’d be better. |
Just fixed that issue! As for banner tints, those values are way darker than what i gave. If you wanna fix it could u provide me with some better gradients :) |
Summary of the problem
They were not skibidi sigma without the background image banner
Describe your changes
now it is skibidi sigma!!!
Checklist