Fixing concurrency issue in VersionSpecificWorkerContextWrapper (#6554) #6648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6648 +/- ##
=========================================
Coverage 83.50% 83.51%
- Complexity 28566 28567 +1
=========================================
Files 1797 1797
Lines 111166 111184 +18
Branches 13965 13965
=========================================
+ Hits 92828 92850 +22
+ Misses 12351 12346 -5
- Partials 5987 5988 +1 ☔ View full report in Codecov by Sentry. |
Boereck
force-pushed
the
fix/concurrency_fix
branch
2 times, most recently
from
c9ecc31 to
fd6414a
Compare
…fhir#6554) When validating if a code is valid against a ValueSet, a potentially cached (and therefore shared) result object was mutated. This mutation is now done on a copy of the result object.
Boereck
force-pushed
the
fix/concurrency_fix
branch
from
fd6414a to
7b4ca30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When validating if a code is valid against a ValueSet, a potentially cached (and therefore shared) result object was mutated. This mutation is now done on a copy of the result object.
Without this change, there might be a concurrent modification on a cached result of
validateCodeInValueSet(item added to issue list). We gotConcurrentModificationExceptions when validating resources with the same problem in parallel.Please let me know if there is an issue with this PR. Unfortunately, due to the concurrent nature of the problem, it seems impossible to test for the absence of the fixed error deterministically.