Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add trip search by license plate number #1022

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

RGvirer
Copy link

@RGvirer RGvirer commented Jan 30, 2025

Created the ability to search for trips by license plate number

Description

screenshots

Created the ability to search for trips by license plate number
@RGvirer RGvirer requested a review from NoamGaash as a code owner January 30, 2025 14:23
@RGvirer RGvirer changed the title Enabled trip search by license plate number feat: add trip search by license plate number Jan 30, 2025
@NoamGaash
Copy link
Member

hello @RGvirer , thanks for your contribution!
could you please clean the diffs a little? seems like your last commit included many files and diffs

@RGvirer RGvirer requested a review from aviv1620 as a code owner February 4, 2025 00:41
@RGvirer
Copy link
Author

RGvirer commented Feb 6, 2025

Hi @NoamGaash ,

I've cleaned up the diffs as requested and made sure everything is in order.
I'd appreciate it if you could take another look and let me know if there's anything else you'd like me to adjust.

Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm trying to understand the code - your contribution is very appreciated. May I ask why do we need planned stops? how do we get this information? It's a little confusing for me because the planning (GTFS data) does not include (as far as I know) any assignment to specific vehicle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants