Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add time box, duplicate transaction check in in atomic batch handle #17780

Open
wants to merge 2 commits into
base: hip-551-batch-txs
Choose a base branch
from

Conversation

iwsimon
Copy link
Contributor

@iwsimon iwsimon commented Feb 7, 2025

Description:

Added transactionValidStart, transactionValidDuration and transaction duplication check for all the inner transactions in AtomicBatchHandler.handle().
Added unit tests and HapiTests.

Related issue(s):

Fixes #17748, #17749

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@iwsimon iwsimon added this to the v0.60 milestone Feb 7, 2025
@iwsimon iwsimon self-assigned this Feb 7, 2025
@iwsimon iwsimon requested review from a team as code owners February 7, 2025 21:31
# Conflicts:
#	hedera-node/test-clients/src/main/java/com/hedera/services/bdd/suites/hip551/AtomicBatchTest.java
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 46176c21 61.90%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (46176c2) Report Missing Report Missing Report Missing
Head commit (754d40b) 98985 72210 72.95%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17780) 21 13 61.90%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 61.90476% with 8 lines in your changes missing coverage. Please review.

Please upload report for BASE (hip-551-batch-txs@46176c2). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...de/app/workflows/handle/DispatchHandleContext.java 20.00% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##             hip-551-batch-txs   #17780   +/-   ##
====================================================
  Coverage                     ?   69.01%           
  Complexity                   ?    22917           
====================================================
  Files                        ?     2645           
  Lines                        ?    99208           
  Branches                     ?    10269           
====================================================
  Hits                         ?    68467           
  Misses                       ?    26847           
  Partials                     ?     3894           
Files with missing lines Coverage Δ
...m/hedera/node/app/spi/workflows/HandleContext.java 82.35% <ø> (ø)
...orkflows/handle/dispatch/ChildDispatchFactory.java 84.78% <100.00%> (ø)
...ode/app/workflows/handle/steps/UserTxnFactory.java 94.40% <100.00%> (ø)
...ows/standalone/impl/StandaloneDispatchFactory.java 97.01% <100.00%> (ø)
...service/util/impl/handlers/AtomicBatchHandler.java 68.75% <100.00%> (ø)
...de/app/workflows/handle/DispatchHandleContext.java 85.08% <20.00%> (ø)

Impacted file tree graph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant