Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui fixes #292

Merged
merged 7 commits into from
Mar 4, 2024
Merged

ui fixes #292

merged 7 commits into from
Mar 4, 2024

Conversation

surendran82
Copy link
Contributor

Description

UI fixes for logo and side nav

Quick Links 🚀

🤖 DX: Assertion Tests

@robertjdominguez robertjdominguez self-requested a review March 4, 2024 16:17
@robertjdominguez
Copy link
Collaborator

Hey, @surendran82 👋

Thanks for this PR! Since you changed docs files, our automated Action assigned Rob as your reviewer 🎉

Before Rob looks over the changes, we ask you to take care of a couple of items:

  • Make sure you've checked over our PR guide on the wiki. It ensures you've done your due diligence on the basics: spelling, heading casings, etc.
  • Rob will need a review from someone on your team to ensure your team-specific content is accurate. Once that's done, ping Rob on Slack, and he'll give a docs review 🔥
  • Additionally, please check this box to confirm your feature works as expected when using the documentation you've written. This is critical to ensuring our users have the information they need.

The docs team aims to get all PRs reviewed within 48 hours of your team doing a review in the form of a content pass. Let Rob know the level of urgency on Slack 👍

@robertjdominguez
Copy link
Collaborator

robertjdominguez commented Mar 4, 2024

DX: Assertion Testing

✅ Diff

The CSS class modifications in the PR help improve the visual consistency of UI elements such as border colors, padding adjustments, and box-shadow consistency. The introduction of a new color variable (--ifm-color-info-dark) ensures theme cohesiveness in the dark mode. Replacing the 'OverviewIconCard' component with a 'kitchen-image-container' div streamlines the HTML structure and may improve the page load performance, although it's unclear why the change was made without additional context regarding functionality or design consistency.

❌ Integrated

The removal of 'OverviewIconCard' and its replacement with a generic div erodes the semantic value and potential interactivity of the card component. Without seeing the broader context of changes, this alteration seems to diminish the overall usability and descriptiveness of the component system. Also, it is noted that certain classes like 'boderRadius0' have typographical errors which can cause confusion and prevent the classes from being used properly. Lastly, the usage of '!important' should be minimized as it could lead to maintenance problems and specificity wars within the stylesheet's integrated form.

Copy link

cloudflare-workers-and-pages bot commented Mar 4, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 91c44f3
Status: ✅  Deploy successful!
Preview URL: https://d3307b0b.v3-docs-eny.pages.dev
Branch Preview URL: https://surendran-v3-docs-04-03-2024.v3-docs-eny.pages.dev

View logs

@seanparkross seanparkross merged commit 3bbcbc0 into main Mar 4, 2024
4 checks passed
@seanparkross seanparkross deleted the surendran/v3-docs-04-03-2024 branch March 4, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants