-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui fixes #292
ui fixes #292
Conversation
Hey, @surendran82 👋 Thanks for this PR! Since you changed docs files, our automated Action assigned Rob as your reviewer 🎉 Before Rob looks over the changes, we ask you to take care of a couple of items:
The docs team aims to get all PRs reviewed within 48 hours of your team doing a review in the form of a content pass. Let Rob know the level of urgency on Slack 👍 |
DX: Assertion Testing✅ DiffThe CSS class modifications in the PR help improve the visual consistency of UI elements such as border colors, padding adjustments, and box-shadow consistency. The introduction of a new color variable (--ifm-color-info-dark) ensures theme cohesiveness in the dark mode. Replacing the 'OverviewIconCard' component with a 'kitchen-image-container' div streamlines the HTML structure and may improve the page load performance, although it's unclear why the change was made without additional context regarding functionality or design consistency. ❌ IntegratedThe removal of 'OverviewIconCard' and its replacement with a generic div erodes the semantic value and potential interactivity of the card component. Without seeing the broader context of changes, this alteration seems to diminish the overall usability and descriptiveness of the component system. Also, it is noted that certain classes like 'boderRadius0' have typographical errors which can cause confusion and prevent the classes from being used properly. Lastly, the usage of '!important' should be minimized as it could lead to maintenance problems and specificity wars within the stylesheet's integrated form. |
Deploying with
|
Latest commit: |
91c44f3
|
Status: | ✅ Deploy successful! |
Preview URL: | https://d3307b0b.v3-docs-eny.pages.dev |
Branch Preview URL: | https://surendran-v3-docs-04-03-2024.v3-docs-eny.pages.dev |
Description
UI fixes for logo and side nav
Quick Links 🚀
🤖 DX: Assertion Tests