Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add architecture docs and refctor deployment docs #805

Merged
merged 20 commits into from
Dec 19, 2024

Conversation

shahidhk
Copy link
Member

@shahidhk shahidhk commented Dec 11, 2024

Description 📝

Revamp the deployment docs section and refactor that into architecture and deployment sections.

Quick Links 🚀

https://shahidhk-architecture-docs.v3-docs-eny.pages.dev/architecture/overview/
https://shahidhk-architecture-docs.v3-docs-eny.pages.dev/deployment/overview/

Assertion Tests 🤖

Architecture docs are added to understand different options of deploying DDN platform. Deployment docs are refactored to have only how-to guides.

@hasura-bot
Copy link
Contributor

Error testing the assertions. Check the logs.

@hasura-bot
Copy link
Contributor

@shahidhk Thanks for your PR! I've assigned @seanparkross to review it.

@hasura-bot
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 52.7%, saving 500.88 KB.

Filename Before After Improvement Visual comparison
static/img/deployment/private_ddn.png 950.16 KB 449.28 KB -52.7% View diff

207 images did not require optimisation.

Copy link

cloudflare-workers-and-pages bot commented Dec 11, 2024

Deploying ddn-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 66315b3
Status:⚡️  Build in progress...

View logs

@seanparkross
Copy link
Collaborator

Awaiting further info and for this to come out of draft to review @shahidhk

@hasura-bot
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 57.5%, saving 670.37 KB.

Filename Before After Improvement Visual comparison
static/img/deployment/private_ddn_byoc_detailed.png 277.04 KB 89.81 KB -67.6% View diff
static/img/deployment/private_ddn_byoc.png 888.82 KB 405.68 KB -54.4% View diff

208 images did not require optimisation.

@shahidhk
Copy link
Member Author

any idea why deploy failed? @hasura/docs ?

@robertjdominguez
Copy link
Collaborator

robertjdominguez commented Dec 12, 2024

any idea why deploy failed? @hasura/docs ?

Logs return a ton of errors around /Architecture/* not being found.

Update the sidebar pathname in the _category_.json to architecture, and it should be fine.

You can test it locally by running yarn build to see if any errors are returned, @shahidhk.

@shahidhk shahidhk marked this pull request as ready for review December 16, 2024 23:54
@shahidhk shahidhk changed the title add architecture docs add architecture docs and refctor deployment docs Dec 16, 2024
@hasura-bot
Copy link
Contributor

hasura-bot commented Dec 17, 2024

Redirects 🔀

Hey, @robertjdominguez & @seanparkross — the following redirects will be needed for deployment:

# TEST ME: https://stage.hasura.io/docs/3.0/deployment/architecture/
location = /docs/3.0/deployment/architecture/ {
    return 301 https://$host/docs/3.0/architecture/overview/;
}
# TEST ME: https://stage.hasura.io/docs/3.0/deployment/private/hasura-hosted/
location = /docs/3.0/deployment/private/hasura-hosted/ {
    return 301 https://$host/docs/3.0/architecture/private/dedicated/;
}
# TEST ME: https://stage.hasura.io/docs/3.0/deployment/deployment/01-create-a-project/
location = /docs/3.0/deployment/deployment/01-create-a-project/ {
    return 301 https://$host/docs/3.0/deployment/ddn/01-create-a-project/;
}
# TEST ME: https://stage.hasura.io/docs/3.0/deployment/deployment/02-create-a-subgraph/
location = /docs/3.0/deployment/deployment/02-create-a-subgraph/ {
    return 301 https://$host/docs/3.0/deployment/ddn/02-create-a-subgraph/;
}
# TEST ME: https://stage.hasura.io/docs/3.0/deployment/deployment/03-deploy-a-connector/
location = /docs/3.0/deployment/deployment/03-deploy-a-connector/ {
    return 301 https://$host/docs/3.0/deployment/ddn/03-deploy-a-connector/;
}
# TEST ME: https://stage.hasura.io/docs/3.0/deployment/deployment/04-deploy-your-supergraph/
location = /docs/3.0/deployment/deployment/04-deploy-your-supergraph/ {
    return 301 https://$host/docs/3.0/deployment/ddn/04-deploy-your-supergraph/;
}
# TEST ME: https://stage.hasura.io/docs/3.0/deployment/deployment/_databaseDocs/_clickHouse/_03-deploy-a-connector/
location = /docs/3.0/deployment/deployment/_databaseDocs/_clickHouse/_03-deploy-a-connector/ {
    return 301 https://$host/docs/3.0/deployment/ddn/_databaseDocs/_clickHouse/_03-deploy-a-connector/;
}
# TEST ME: https://stage.hasura.io/docs/3.0/deployment/deployment/_databaseDocs/_go/_03-deploy-a-connector/
location = /docs/3.0/deployment/deployment/_databaseDocs/_go/_03-deploy-a-connector/ {
    return 301 https://$host/docs/3.0/deployment/ddn/_databaseDocs/_go/_03-deploy-a-connector/;
}
# TEST ME: https://stage.hasura.io/docs/3.0/deployment/deployment/_databaseDocs/_graphql/_03-deploy-a-connector/
location = /docs/3.0/deployment/deployment/_databaseDocs/_graphql/_03-deploy-a-connector/ {
    return 301 https://$host/docs/3.0/deployment/ddn/_databaseDocs/_graphql/_03-deploy-a-connector/;
}
# TEST ME: https://stage.hasura.io/docs/3.0/deployment/deployment/_databaseDocs/_mongoDB/_03-deploy-a-connector/
location = /docs/3.0/deployment/deployment/_databaseDocs/_mongoDB/_03-deploy-a-connector/ {
    return 301 https://$host/docs/3.0/deployment/ddn/_databaseDocs/_mongoDB/_03-deploy-a-connector/;
}
# TEST ME: https://stage.hasura.io/docs/3.0/deployment/deployment/_databaseDocs/_openAPI/_03-deploy-a-connector/
location = /docs/3.0/deployment/deployment/_databaseDocs/_openAPI/_03-deploy-a-connector/ {
    return 301 https://$host/docs/3.0/deployment/ddn/_databaseDocs/_openAPI/_03-deploy-a-connector/;
}
# TEST ME: https://stage.hasura.io/docs/3.0/deployment/deployment/_databaseDocs/_postgreSQL/_03-deploy-a-connector/
location = /docs/3.0/deployment/deployment/_databaseDocs/_postgreSQL/_03-deploy-a-connector/ {
    return 301 https://$host/docs/3.0/deployment/ddn/_databaseDocs/_postgreSQL/_03-deploy-a-connector/;
}
# TEST ME: https://stage.hasura.io/docs/3.0/deployment/deployment/_databaseDocs/_python/_03-deploy-a-connector/
location = /docs/3.0/deployment/deployment/_databaseDocs/_python/_03-deploy-a-connector/ {
    return 301 https://$host/docs/3.0/deployment/ddn/_databaseDocs/_python/_03-deploy-a-connector/;
}
# TEST ME: https://stage.hasura.io/docs/3.0/deployment/deployment/_databaseDocs/_typeScript/_03-deploy-a-connector/
location = /docs/3.0/deployment/deployment/_databaseDocs/_typeScript/_03-deploy-a-connector/ {
    return 301 https://$host/docs/3.0/deployment/ddn/_databaseDocs/_typeScript/_03-deploy-a-connector/;
}
# TEST ME: https://stage.hasura.io/docs/3.0/deployment/deployment/index/
location = /docs/3.0/deployment/deployment/index/ {
    return 301 https://$host/docs/3.0/deployment/ddn/index/;
}
# TEST ME: https://stage.hasura.io/docs/3.0/deployment/deployment/_category_.json
location = /docs/3.0/deployment/deployment/_category_.json {
    return 301 https://$host/docs/3.0/OG-FILE-WAS-DELETED-REPLACE-ME-WITH-NEW-LOCATION;
}
# TEST ME: https://stage.hasura.io/docs/3.0/deployment/private/data-plane-collaboration/
location = /docs/3.0/deployment/private/data-plane-collaboration/ {
    return 301 https://$host/docs/3.0/deployment/private-ddn/data-plane-collaboration/;
}
# TEST ME: https://stage.hasura.io/docs/3.0/deployment/private/_category_.json
location = /docs/3.0/deployment/private/_category_.json {
    return 301 https://$host/docs/3.0/OG-FILE-WAS-DELETED-REPLACE-ME-WITH-NEW-LOCATION;
}
# TEST ME: https://stage.hasura.io/docs/3.0/deployment/private/self-hosted/_category_.json
location = /docs/3.0/deployment/private/self-hosted/_category_.json {
    return 301 https://$host/docs/3.0/OG-FILE-WAS-DELETED-REPLACE-ME-WITH-NEW-LOCATION;
}
# TEST ME: https://stage.hasura.io/docs/3.0/deployment/private/self-hosted/self-hosted-deployment/
location = /docs/3.0/deployment/private/self-hosted/self-hosted-deployment/ {
    return 301 https://$host/docs/3.0/OG-FILE-WAS-DELETED-REPLACE-ME-WITH-NEW-LOCATION;
}
# TEST ME: https://stage.hasura.io/docs/3.0/deployment/serverless/
location = /docs/3.0/deployment/serverless/ {
    return 301 https://$host/docs/3.0/OG-FILE-WAS-DELETED-REPLACE-ME-WITH-NEW-LOCATION;
}

@hasura-bot
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 55.4%, saving 468.85 KB.

Filename Before After Improvement Visual comparison
static/img/deployment/private_ddn_self_hosted.png 846.88 KB 378.03 KB -55.4% View diff

211 images did not require optimisation.

Copy link
Collaborator

@seanparkross seanparkross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have applied a bunch of nit commits directly. Main thing is there was no consistency with the capitalisation of Data Plane and Control Plane. I have gone with title case throughout as that was more common. Can change to all lowercase if needed.

@seanparkross seanparkross enabled auto-merge (squash) December 19, 2024 12:28
@seanparkross seanparkross merged commit 67fea30 into main Dec 19, 2024
4 of 5 checks passed
@seanparkross seanparkross deleted the shahidhk/architecture-docs branch December 19, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants