Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update collaboration/comments.mdx based on latest features #868

Merged
merged 7 commits into from
Feb 3, 2025

Conversation

julian-mayorga
Copy link
Contributor

@julian-mayorga julian-mayorga commented Feb 3, 2025

Description 📝

Update both copy and screenshots based on latest comment changes

Quick Links 🚀

Assertion Tests 🤖

@hasura-bot
Copy link
Contributor

Error testing the assertions. Check the logs.

@hasura-bot
Copy link
Contributor

@julian-mayorga Thanks for your PR! I've assigned @robertjdominguez to review it.

@hasura-bot
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 43.6%, saving 967.51 KB.

Filename Before After Improvement Visual comparison
static/img/get-started/comments_builds.png 326.62 KB 173.38 KB -46.9% View diff
static/img/get-started/comments_explorer.png 457.43 KB 265.31 KB -42.0% View diff
static/img/get-started/comments_graphiql.png 461.98 KB 260.07 KB -43.7% View diff
static/img/get-started/comments_insights.png 453.98 KB 252.44 KB -44.4% View diff
static/img/get-started/comments_notification.png 65.31 KB 37.14 KB -43.1% View diff
static/img/get-started/console_comment-create.png 452.69 KB 262.16 KB -42.1% View diff

216 images did not require optimisation.

Copy link

cloudflare-workers-and-pages bot commented Feb 3, 2025

Deploying ddn-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: f7221aa
Status: ✅  Deploy successful!
Preview URL: https://6cb42a8f.v3-docs-eny.pages.dev
Branch Preview URL: https://julian-comments-refresh.v3-docs-eny.pages.dev

View logs

Copy link
Collaborator

@robertjdominguez robertjdominguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @julian-mayorga — just some grammar nits for consistency in how we're treating terms like supergraph 🤙

Please commit them before merging 🙂

docs/collaboration/comment.mdx Outdated Show resolved Hide resolved
docs/collaboration/comment.mdx Outdated Show resolved Hide resolved
docs/collaboration/comment.mdx Outdated Show resolved Hide resolved
docs/collaboration/comment.mdx Outdated Show resolved Hide resolved
docs/collaboration/comment.mdx Outdated Show resolved Hide resolved
@julian-mayorga
Copy link
Contributor Author

Thanks, @julian-mayorga — just some grammar nits for consistency in how we're treating terms like supergraph 🤙

Please commit them before merging 🙂

Appreciate the review and comments 🙏

@julian-mayorga julian-mayorga enabled auto-merge (squash) February 3, 2025 14:09
@julian-mayorga julian-mayorga merged commit bff6daf into main Feb 3, 2025
4 of 5 checks passed
@julian-mayorga julian-mayorga deleted the julian/comments-refresh branch February 3, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants