Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial MySQL configuration docs #881

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

pranshi06
Copy link
Contributor

@pranshi06 pranshi06 commented Feb 6, 2025

Description 📝

Adds configuration documentation for the MySQL connector

Quick Links 🚀

Assertion Tests 🤖

@hasura-bot
Copy link
Contributor

@pranshi06 Thanks for your PR! I've assigned @seanparkross to review it.

@hasura-bot
Copy link
Contributor

hasura-bot commented Feb 6, 2025

DX: Assertion Testing

✅ Diff

The PR diff shows a coherent addition of MySQL documentation. It includes an index file for navigation, a category descriptor for sidebar ordering, and a comprehensive configuration reference. The structure and examples provided in the configuration.mdx are well-detailed and follow a consistent format with other connector documentation. Ensure to check that all internal links are correct and functional.

✅ Integrated

The integration of the MySQL documentation with the existing files is coherent. The sidebar position has been updated for Oracle to maintain the correct order, keeping MySQL in sequence with other database connectors. PostgreSQL's sidebar position has also been corrected to reflect the new addition. All changes respect the established conventions and improve the overall usability by adding relevant information about MySQL configuration in a well-structured manner.

Copy link

cloudflare-workers-and-pages bot commented Feb 6, 2025

Deploying ddn-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: b32dc21
Status: ✅  Deploy successful!
Preview URL: https://27b0ebdd.v3-docs-eny.pages.dev
Branch Preview URL: https://pranshi-docs-add-mysql-confi.v3-docs-eny.pages.dev

View logs

@pranshi06 pranshi06 requested review from robertjdominguez and removed request for seanparkross February 7, 2025 05:28
@pranshi06 pranshi06 marked this pull request as ready for review February 7, 2025 05:28
Copy link
Collaborator

@robertjdominguez robertjdominguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @pranshi06!

@robertjdominguez robertjdominguez merged commit dc1bfa9 into main Feb 7, 2025
4 checks passed
@robertjdominguez robertjdominguez deleted the pranshi/docs/add-mysql-config-docs branch February 7, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants