add env var documentation for elasticsearch #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DX: Assertion Testing✅ DiffThe added Elasticsearch configuration tab is informative and consistent with the format of existing database configurations. Including the ENV variables, along with the examples and descriptions, are very helpful for users trying to connect an Elasticsearch source. ✅ IntegratedThe documentation PR integrates well with existing content. Cross-linking to the 'Connect to a source' section from the Elasticsearch documentation page makes it easy for users to find the relevant information on how to connect to an Elasticsearch instance, enhancing the overall usability of the documentation. |
|
@m-Bilal Thanks for your PR! I've assigned @robertjdominguez to review it. |
Deploying ddn-docs with
|
| Latest commit: |
3d20eda
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://de72f8c8.v3-docs-eny.pages.dev |
| Branch Preview URL: | https://m-bilal-docs-elasticsearch-e.v3-docs-eny.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Adds environment variable documentation for Elasticsearch
Quick Links 🚀
Assertion Tests 🤖