Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a capability for transactional mutations #80

Merged
merged 5 commits into from
Jan 28, 2024
Merged

Conversation

soupi
Copy link
Contributor

@soupi soupi commented Jan 10, 2024

This PR encodes the support a connector offers wrt mutations in types.
It introduces a new capability, mutation, to signal whether the connector supports mutations, and a field in MutationCapabilities, transactional, to signal whether the connector support running multiple mutations in a single transaction.

Additional discussion on Slack: https://hasurahq.slack.com/archives/C065TFX2V2Q/p1702996285519119

@soupi soupi requested review from paf31 and codedmart as code owners January 10, 2024 09:02
@soupi soupi marked this pull request as draft January 10, 2024 09:41
@soupi soupi marked this pull request as ready for review January 10, 2024 09:52
ndc-client/src/models.rs Outdated Show resolved Hide resolved
@paf31
Copy link
Collaborator

paf31 commented Jan 18, 2024

@0x777 Could you please add your notes regarding the GraphQL/engine side of things here?

@paf31 paf31 changed the title add a capability for mutations Add a capability for mutations Jan 23, 2024
Copy link
Collaborator

@paf31 paf31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! Once I figure out the release plan, I'll merge this.

@soupi soupi changed the title Add a capability for mutations Add a capability for transactional mutations Jan 24, 2024
@paf31 paf31 merged commit fc9aa01 into main Jan 28, 2024
8 checks passed
@paf31 paf31 deleted the gil/mutation-capability branch January 28, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants