Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Notifications #161

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add Notifications #161

wants to merge 2 commits into from

Conversation

haydenbleasel
Copy link
Owner

@haydenbleasel haydenbleasel commented Oct 31, 2024

This pull request introduces the integration of Knock notifications into the project, along with several dependency updates and new environment variables. The most important changes include adding Knock API keys to environment configurations, updating the layout to include the NotificationsProvider, and adding new dependencies for Knock.

Knock Integration:

  • Added KNOCK_API_KEY and KNOCK_FEED_CHANNEL_ID to .github/workflows/build.yml and apps/app/.env.example files. [1] [2]
  • Updated apps/app/app/(authenticated)/layout.tsx to include NotificationsProvider and ensure user authentication before rendering the layout. [1] [2] [3]
  • Created a new NotificationsProvider component in packages/design-system/providers/notifications.tsx to wrap the application with Knock's notification context.

Dependency Management:

  • Added Knock-related dependencies (@knocklabs/node, @knocklabs/react) to packages/design-system/package.json.
  • Updated pnpm-lock.yaml to include various new dependencies and their versions, such as @knocklabs/client, @knocklabs/node, and @knocklabs/react. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17]

New Utility:

  • Created a new utility for Knock API integration in packages/design-system/lib/knock.ts.

@haydenbleasel haydenbleasel added the minor Increment the minor version when merged label Oct 31, 2024
@haydenbleasel haydenbleasel self-assigned this Oct 31, 2024
Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-forge ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2024 7:52am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant