Use many break tokens. #53
Conversation
|
Thanks for this, can you please explain this in a little more details? Also, please can you avoid changing the hash syntax in all of the tests? This makes it really hard to look at history and is unnecessary. 😄 |
Create new break_tokens attribute, break_token is deprecated. Signed-off-by: Kirill Zaitsev <[email protected]>
|
@parndt Thanks, il change break_token to break_tokens and transform this to array. It simple, we can have more than one break token. I have some projects when changed wysiwyg, and as a consequence pagebreak ( im use it like break token ) changes too. Of course I can change it all pagebreaks :), but i think we can use array of tokens. |
| @@ -7,11 +7,20 @@ def initialize(original_html, options = {}) | |||
| @omission = options[:omission] || TruncateHtml.configuration.omission | |||
| @word_boundary = (options.has_key?(:word_boundary) ? options[:word_boundary] : TruncateHtml.configuration.word_boundary) | |||
| @break_token = options[:break_token] || TruncateHtml.configuration.break_token || nil | |||
| @break_tokens = options[:break_tokens] || TruncateHtml.configuration.break_tokens || [] | |||
| @break_tokens << @break_token | |||
There was a problem hiding this comment.
since @break_token can be set to nil on line 9, you may want to add a protection here so you're not shoveling a nil value into your @break_tokens array. maybe something like @break_tokens << @break_token if @break_token.
if there are any nil values in @break_tokens, the code will throw an error at line 83:
NoMethodError - undefined method '<<' for nil:NilClass
Create new break_tokens attribute, break_token is deprecated.