This repository has been archived by the owner on Sep 20, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 67
Issues #41 Add errors when assert operators. #59
Open
vonglasow
wants to merge
1
commit into
hoaproject:master
Choose a base branch
from
vonglasow:errors
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,85 @@ | ||
<?php | ||
|
||
/** | ||
* Hoa | ||
* | ||
* | ||
* @license | ||
* | ||
* New BSD License | ||
* | ||
* Copyright © 2007-2015, Ivan Enderlin. All rights reserved. | ||
* | ||
* Redistribution and use in source and binary forms, with or without | ||
* modification, are permitted provided that the following conditions are met: | ||
* * Redistributions of source code must retain the above copyright | ||
* notice, this list of conditions and the following disclaimer. | ||
* * Redistributions in binary form must reproduce the above copyright | ||
* notice, this list of conditions and the following disclaimer in the | ||
* documentation and/or other materials provided with the distribution. | ||
* * Neither the name of the Hoa nor the names of its contributors may be | ||
* used to endorse or promote products derived from this software without | ||
* specific prior written permission. | ||
* | ||
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" | ||
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE | ||
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE | ||
* ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDERS AND CONTRIBUTORS BE | ||
* LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR | ||
* CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF | ||
* SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS | ||
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN | ||
* CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) | ||
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE | ||
* POSSIBILITY OF SUCH DAMAGE. | ||
*/ | ||
|
||
namespace Hoa\Ruler\Test\Unit\Model; | ||
|
||
use Hoa\Test; | ||
use Hoa\Ruler as LUT; | ||
|
||
/** | ||
* Class \Hoa\Ruler\Test\Unit\Model\Asserter. | ||
* | ||
* Test suite of the asserter object of the visitor. | ||
* | ||
* @author Alexis von Glasow <[email protected]> | ||
* @copyright Copyright © 2007-2015 Alexis von Glasow. | ||
* @license New BSD License | ||
*/ | ||
|
||
class Asserter extends Test\Unit\Suite { | ||
|
||
public function case_keep_errors ( ) { | ||
$this | ||
->given( | ||
$ruler = new LUT(), | ||
$fExecuted = false, | ||
$asserter = $ruler->getDefaultAsserter(), | ||
$asserter->setOperator( | ||
'f', | ||
function ( $a = false ) use ( &$fExecuted ) { | ||
|
||
$fExecuted = true; | ||
|
||
return $a; | ||
} | ||
), | ||
$rule = 'f(false)' | ||
) | ||
->when($result = $ruler->assert($rule, new LUT\Context())) | ||
->then | ||
->boolean($result) | ||
->isFalse() | ||
->boolean($fExecuted) | ||
->isTrue() | ||
->boolean($asserter->hasError()) | ||
->isTrue() | ||
->array($asserter->getErrors()) | ||
->isNotEmpty() | ||
->hasKey('f') | ||
; | ||
} | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why
false
means a failed computation?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the first assumption, generally when something is
false
, this come from an error. But you're right sometimes we want to havefalse
as a correct value. This is also the reason why the operatornot
exist. I see this in two way first is to found if this operator is used (not
operator) and invert the condition. But sometimes the value which should be used to raise an error could be other than "false". So the second way should be to add thefalse
value in operator to identify from which value you can add an error for this operator.What do you think ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about letting the operator to register an error somewhere instead?