Add padding to refresh interval to avoid text getting cut off #4119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JBassett
approved these changes
Jan 6, 2024
|
You only needed horizontal padding here, now it's quite hard to see the text can scroll on the largest size... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We got a review failure from Google with a screenshot this time!
Adding padding to this screen to prevent the text from getting cut off like that. I tried to move to
ThemeLazyColumnhowever the rotary input does not play nice so the best option seemed to be adding some sane paddingScreenshots
After fix using largest font size in Pixel Watch (one side effect of this change is that not many elements are visible in the picker however we do need to push things down a bit so this might be expected in larger screen sizes):
Still behaves fine in default text size:
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes