Support for Thread "import credentials" from frontend #4128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add support for the frontend action to import Thread credentials, or better said export Thread credentials from the device. This is essentially a very basic sync.
- Change names and order of reused Matter code for Thread importing to prevent potential confusion
jpelgrom
force-pushed
the
thread-import-credentials-frontend
branch
from
e72dbf2 to
d65285e
Compare
JBassett
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support the frontend
thread/import_credentialsaction, shown as a button on the Thread config page, which will export the preferred Thread credential from the device (if the device doesn't prefer a HA credential) to the server.This partially re-uses the existing Thread credential sync logic from Matter commissioning.
Screenshots
Video showing the flow, first denying the permission/failure and then success:
thread-import.mp4
Link to pull request in Documentation repository
n/a
Any other notes