Update splash screen icon to match style/size of frontend #4937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use the same style and size of icon on the splash screen as the frontend to make the transition smoother - Also update onboarding screen with the same icon - Don't set splash screen icon as placeholder in camera/media player widgets as they are not visible anyway
dshokouhi
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use the same style and size of icon on the splash screen as the frontend to make the transition smoother. This doesn't include the positioning - it may (almost) line up but no guarantees as that requires more device testing and seems to require us going edge to edge on modern devices which is currently blocked by webview / frontend support (and edge to edge shouldn't be combined with this PR). Related: #3142
Also update onboarding screen with the same icon, and don't set splash screen icon as placeholder in camera/media player widgets as they are not visible anyway.
Screenshots
halaunch-2.mp4
Link to pull request in Documentation repository
n/a
Any other notes